From: Gergo Koteles <soyer@irl.hu>
To: Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
Baojun Xu <baojun.xu@ti.com>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Gergo Koteles <soyer@irl.hu>
Subject: [PATCH 12/16] ASoC: tas2781: move set_drv_data outside tasdevice_init
Date: Thu, 7 Dec 2023 01:04:28 +0100 [thread overview]
Message-ID: <bb94a9560f8a7453a77ba736f4d99d3fa90259e7.1701906455.git.soyer@irl.hu> (raw)
In-Reply-To: <cover.1701906455.git.soyer@irl.hu>
allow driver specific driver data in tas2781-hda-ic2c and tas2781-i2c
Signed-off-by: Gergo Koteles <soyer@irl.hu>
---
sound/pci/hda/tas2781_hda_i2c.c | 2 ++
sound/soc/codecs/tas2781-comlib.c | 2 --
sound/soc/codecs/tas2781-i2c.c | 2 ++
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c
index f28383597ca8..290c41194139 100644
--- a/sound/pci/hda/tas2781_hda_i2c.c
+++ b/sound/pci/hda/tas2781_hda_i2c.c
@@ -734,6 +734,8 @@ static int tas2781_hda_i2c_probe(struct i2c_client *clt)
if (!tas_priv)
return -ENOMEM;
+ dev_set_drvdata(&clt->dev, tas_priv);
+
if (strstr(dev_name(&clt->dev), "TIAS2781")) {
device_name = "TIAS2781";
tas_priv->load_calibration = load_calibration_efi_1;
diff --git a/sound/soc/codecs/tas2781-comlib.c b/sound/soc/codecs/tas2781-comlib.c
index 635f97db033b..0c04735dd575 100644
--- a/sound/soc/codecs/tas2781-comlib.c
+++ b/sound/soc/codecs/tas2781-comlib.c
@@ -316,8 +316,6 @@ int tasdevice_init(struct tasdevice_priv *tas_priv)
tas_priv->tasdevice[i].cur_conf = -1;
}
- dev_set_drvdata(tas_priv->dev, tas_priv);
-
mutex_init(&tas_priv->codec_lock);
out:
diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c
index 55cd5e3c23a5..917b1c15f71d 100644
--- a/sound/soc/codecs/tas2781-i2c.c
+++ b/sound/soc/codecs/tas2781-i2c.c
@@ -689,6 +689,8 @@ static int tasdevice_i2c_probe(struct i2c_client *i2c)
if (!tas_priv)
return -ENOMEM;
+ dev_set_drvdata(&i2c->dev, tas_priv);
+
if (ACPI_HANDLE(&i2c->dev)) {
acpi_id = acpi_match_device(i2c->dev.driver->acpi_match_table,
&i2c->dev);
--
2.43.0
next prev parent reply other threads:[~2023-12-07 0:05 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 0:58 [PATCH 00/16] ALSA: hda/tas2781: Add tas2563 support Gergo Koteles
2023-12-06 23:59 ` [PATCH 01/16] ASoC: tas2781: add support for fw version 0x0503 Gergo Koteles
2023-12-06 23:59 ` [PATCH 02/16] ALSA: hda/tas2781: leave hda_component in usable state Gergo Koteles
2023-12-06 23:59 ` [PATCH 03/16] ASoC: tas2781: disable regmap regcache Gergo Koteles
2023-12-07 18:20 ` Mark Brown
2023-12-07 20:19 ` Gergo Koteles
2023-12-07 20:36 ` Mark Brown
2023-12-07 21:12 ` Gergo Koteles
2023-12-07 22:39 ` Mark Brown
2023-12-15 1:17 ` Gergo Koteles
2023-12-15 12:55 ` Mark Brown
2023-12-15 14:42 ` Gergo Koteles
2023-12-15 15:02 ` Mark Brown
2023-12-06 23:59 ` [PATCH 04/16] ALSA: hda/tas2781: handle missing calibration data Gergo Koteles
2023-12-06 23:59 ` [PATCH 05/16] ALSA: hda/tas2781: fix typos in comment Gergo Koteles
2023-12-06 23:59 ` [PATCH 06/16] ASoC: tas2781: add ptrs to calibration functions Gergo Koteles
2023-12-07 18:22 ` Mark Brown
2023-12-06 23:59 ` [PATCH 07/16] ALSA: hda/tas2781: load_calibration just load Gergo Koteles
2023-12-06 23:59 ` [PATCH 08/16] ASoC: tas2781: add configurable global_addr Gergo Koteles
2023-12-06 23:59 ` [PATCH 09/16] ALSA: hda/tas2781: add TAS2563 support for 14ARB7 Gergo Koteles
2023-12-07 0:04 ` [PATCH 10/16] ASoC: tas2781: check negative indexes Gergo Koteles
2023-12-07 0:04 ` [PATCH 11/16] ASoC: tas2781: use 0 as default prog/conf index Gergo Koteles
2023-12-07 18:28 ` Mark Brown
2023-12-09 18:20 ` Gergo Koteles
2023-12-07 0:04 ` Gergo Koteles [this message]
2023-12-07 0:04 ` [PATCH 13/16] ALSA: hda/tas2781: remove sound controls in unbind Gergo Koteles
2023-12-07 12:21 ` kernel test robot
2023-12-07 16:00 ` kernel test robot
2023-12-07 0:04 ` [PATCH 14/16] ALSA: hda/tas2781: call cleaner functions only once Gergo Koteles
2023-12-07 0:04 ` [PATCH 15/16] ALSA: hda/tas2781: reset the amp before component_add Gergo Koteles
2023-12-07 0:04 ` [PATCH 16/16] ALSA: hda/tas2781: configure the amp after firmware load Gergo Koteles
2023-12-07 13:55 ` [PATCH 00/16] ALSA: hda/tas2781: Add tas2563 support Mark Brown
2023-12-07 14:38 ` Takashi Iwai
2023-12-30 0:09 ` [PATCH v2 0/4] " Gergo Koteles
2023-12-30 0:09 ` [PATCH v2 1/4] ALSA: hda/tas2781: add ptrs to calibration functions Gergo Koteles
2023-12-30 0:09 ` [PATCH v2 2/4] ALSA: hda/tas2781: add configurable global i2c address Gergo Koteles
2023-12-30 0:09 ` [PATCH v2 3/4] ALSA: hda/tas2781: add TAS2563 support for 14ARB7 Gergo Koteles
2023-12-30 0:09 ` [PATCH v2 4/4] ALSA: hda/tas2781: add fixup for Lenovo 14ARB7 Gergo Koteles
2023-12-30 16:59 ` [PATCH v2 0/4] ALSA: hda/tas2781: Add tas2563 support Takashi Iwai
2023-12-30 20:18 ` Gergo Koteles
2023-12-31 8:33 ` Takashi Iwai
2024-01-02 15:37 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb94a9560f8a7453a77ba736f4d99d3fa90259e7.1701906455.git.soyer@irl.hu \
--to=soyer@irl.hu \
--cc=alsa-devel@alsa-project.org \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®