From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28C80C433E1 for ; Tue, 9 Jun 2020 13:52:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F163720737 for ; Tue, 9 Jun 2020 13:52:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W7DwXTum" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730201AbgFINw0 (ORCPT ); Tue, 9 Jun 2020 09:52:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728388AbgFINwZ (ORCPT ); Tue, 9 Jun 2020 09:52:25 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F14DC05BD1E; Tue, 9 Jun 2020 06:52:25 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id e9so10315401pgo.9; Tue, 09 Jun 2020 06:52:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=388zbEBpvCQ90jZ9L0TJj0YYmLQ9y5HlGdptwpC6Udw=; b=W7DwXTumWdAzSGW3aINNOCLYrVGZ6g0ELLEIFJ0fNCLGUFt3H65XsN+ScWIrF0+eN+ pnyAZqInztut6wB64KvBTN4wFjzi4m2BeW5JEWVDwbvHO0LjQvZ96r+mtnB9GCz5fA0v PIBfkV1NTQXbi9t7e+h+jEpTbsd8iLpNB9OtGWaEk8MtmbbAsDOOaJF9Xty/uaAkMpTy N0kZYjuy+PlqCr0+MFieaI/8gMgX8UQFF1FZKPhhVya1bF3hsGsQXsircIzCK7cjUR/E CcW/HeAK6fXNRtnrWkf/5KyKumAbVC1TM0r9auVxEE49bqXD+wtjKtALX+9QPIMhRl0G 2H5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=388zbEBpvCQ90jZ9L0TJj0YYmLQ9y5HlGdptwpC6Udw=; b=sk3Yi4TLX54vZCpDMAbyVpbSj6GmptZzdAtiiFtUSu58G7Sm8xHXvUgNZ+PlK0EveS YyKqOkv6z90cUJGbkPT1beXjgDsEU9kjk8aBcGejRc3VJ60RRmXQFBRARUeQrv8z1zQ9 DEegKh6ABNH/ee7ILZIN85A1Z1FVAKICi7dQPTsvySacCurdRmocVC3kb2jt+eDdyor2 4ys5m8HhlGzschhzRXKPyCN0AaUJczj8xGgjwn+AndpZrHOuww+QcjKZbpydpLsMGiFM T7W7ixwyaL6d2k+zoacOvKNWfDao2K63hNGg9InIQ5fH4E2gX6tFndhKeXLAC2ACAp+7 XIXg== X-Gm-Message-State: AOAM531bK1y6KFoV2nKbSECYY118OfQKoOXMqQgjuGCVHXbxQTNl4ud/ eyvarOmHQuFRml++yqwUt31x/NQK X-Google-Smtp-Source: ABdhPJywlCYiwn7Ld19TQw/gTGtQBz1/dLgBVykGNHXBin/MoRp0LRhdYxsQKY74YXvcEs55FuRHdQ== X-Received: by 2002:aa7:9093:: with SMTP id i19mr25124567pfa.152.1591710744369; Tue, 09 Jun 2020 06:52:24 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id nl5sm3073559pjb.36.2020.06.09.06.52.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2020 06:52:23 -0700 (PDT) Subject: Re: [PATCH] Input: joystick - work around "adi" module name confict To: Arnd Bergmann , Dmitry Torokhov Cc: Greg Kroah-Hartman , Masahiro Yamada , linux-input@vger.kernel.org, Markus Koch , linux-kernel@vger.kernel.org References: <20200609100643.1245061-1-arnd@arndb.de> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= Message-ID: Date: Tue, 9 Jun 2020 06:52:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200609100643.1245061-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/9/20 3:06 AM, Arnd Bergmann wrote: > Making module name conflicts a fatal error breaks sparc64 > allmodconfig: > > Error log: > error: the following would cause module name conflict: > drivers/char/adi.ko > drivers/input/joystick/adi.ko > > Renaming one of the modules would solve the problem, but then cause other > problems because neither of them is automatically loaded and changing > the name is likely to break any setup that relies on manually loading > it by name. > > As there is probably no sparc64 system with this kind of ancient joystick > attached, work around it by adding a Kconfig dependency that forbids > them from both being modules. It is still possible to build the joystick > driver if the sparc64 adi driver is built-in. > > Reported-by: Guenter Roeck > Acked-by: Greg Kroah-Hartman > Cc: Masahiro Yamada > Cc: Dmitry Torokhov > Cc: linux-input@vger.kernel.org > Signed-off-by: Arnd Bergmann Reviewed-by: Guenter Roeck > --- > This should get merged through the kbuild tree together > with the patch that turns the warning into an error, if the > joystick maintainers are ok with the hack. > --- > drivers/input/joystick/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig > index 940b744639c7..6f73f02059b5 100644 > --- a/drivers/input/joystick/Kconfig > +++ b/drivers/input/joystick/Kconfig > @@ -45,6 +45,7 @@ config JOYSTICK_A3D > config JOYSTICK_ADI > tristate "Logitech ADI digital joysticks and gamepads" > select GAMEPORT > + depends on ADI!=m # avoid module name conflict > help > Say Y here if you have a Logitech controller using the ADI > protocol over the PC gameport. >