From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B73C337E2EC for ; Mon, 13 Jul 2026 10:34:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783938882; cv=none; b=mDepWBM5JMo+a8cd1tNsWxLSyB+ZkbbMhS/d8QCsI/6CHBQqc5qHITISv713UdsFTbNv2FkTlw4PUfh84rz3qweSkEvV/Z/hg4GmfIDzlSeJVyCVCdz46+xsZnw4OPbJu5PYeKXZBn4SJjSQlradExDVjTLQw+9AYT3IB5idQV8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783938882; c=relaxed/simple; bh=a2ns7VJ1cGEf33swZ803LYzM4m/USCko3oPVUeKJ0KQ=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=rTPVQIFGg6NrA2rQKrxvkBOjWx8winxDCU1CHTB+UkA6rbiWut/r03/IDZBSP/Fi3icO0vjNhOZm+kxP6grGmDGmXWEY6t84iVpuDr9ZO2garXLvdDKh+RjS769VtDfxbo1yye1gFfjqp/rRmDcy+Q+lpVOTb0PgOzaYcOLq/hY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XiZnhiXp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fiASGFSy; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XiZnhiXp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fiASGFSy" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66D6Nkfm668628 for ; Mon, 13 Jul 2026 10:34:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2FQsviU3LabeSh9mHc1aSHq4d7ML6OgJAdel+fkcW8g=; b=XiZnhiXpEI/1l03R 1m0V7lE2x3Wnf+rGk2dtXKwrqGE4oPK5GJOdu0bO8t+7X/7h/9vIafx1agA92lvc U/WKNNZTFCMruVa62RnpxQLfl7TtwfiKPoL/LLgUggJ9rZgXsDkcNcG8soH95J7o K0b0Wjs6Yt0EYt0lksu5VeDG3jKgM19E9X0vJahuvZexwSgJEnyf7YZb04DcKxiU MiEew2aJ2LAVT2Da0gZg98cLp6LePtnP6/U4jPVxovvH+4oOyPON6N2hmCG4TGB1 Oknq9JPU2UJeftVqiDD2MNeKj9IUB1VPoSBB5LwLW7ig/kR6Q+eeUJY4F3Jk/n0a wteJgg== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fcjnm23tc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Jul 2026 10:34:41 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c15c77619so9520561cf.1 for ; Mon, 13 Jul 2026 03:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783938880; x=1784543680; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=2FQsviU3LabeSh9mHc1aSHq4d7ML6OgJAdel+fkcW8g=; b=fiASGFSyqSHDuczpRPSQfGkkTQDedY1mqOy13pySPBcmN47/0tI8SdAUUcDdLm5xXR Tp5fiNUF2kNH0c2BZj360oROFdeJ0BqTpU1Z1aJfPxHm1dh/7I706waTz7IFn33SOjMi 2Zf4u/J0+khpFWE6a773zl16XO2BTvtLUdiEaugBDWFv9GRyHfM5fwciZBdyy1fhudbT kh+VHW4N0wAT+g78d8aCuwGY01c65x8OumrN/08c0tb3xtAWpnLfELmAyxzQIux4AGeN iSX0VsY9M+zI/B0qBVskmI4jTFyN+RBnQqH6U9IdqjQ0E0ulC3GRrGgd3zbOrtQosIKk 1Ltg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783938880; x=1784543680; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2FQsviU3LabeSh9mHc1aSHq4d7ML6OgJAdel+fkcW8g=; b=faLDGjqiQszk12oETpzb3X7pl0DG3+M8skszAuMtz/NADfDWP0WNYatgBuIMLtKwZN o6hNBWtrFgnrA4E6KEwWUiLwJzCu/2WjP5fuYVtGklT2dV52noGNnN5qNKxUD7k4d8lo 18I8pTKUk5Ekzkpyt0Y6rc3ESJCanJEuFMNciXt5bspoPvH2nDDgul3Q1erCLcoglPrd moIjn+6DK8GH0wnHoZ2XIzNtOHUWBUptr9Qqc7UAvvDH+Cu3kEPoXLowNhoLvEzTOQkk UMyEGYM6V1SOobPj9vGmKqURZsW9PxtooLodcqEtdxN5vy4zhBdPTeC/2d52s03Njjt8 6fRg== X-Forwarded-Encrypted: i=1; AHgh+RqHMyU0SPb/T0g1oDn9hRmdQHc3beuki+vyU1fCqREczNRQuzeLsOEowKN8Ce0e5W+MC/BkIJ/2ka+eo8Y=@vger.kernel.org X-Gm-Message-State: AOJu0YywIjwZLoO1W6Aj1Ncs9u5lW8Ul6aeV6YQwGcpAPg81PhV4/qxO QOjhRSApBHon7sMGVNPIE8nSs7acKKDPct1ia5MovP958udo4n+o8UCuKYrSVucBjJj7BN2Sro+ J1SY4Vbk5VMzclo4/9h1In+zQN3T3v7NmFLh6/GXf+11Mc2OSRpLfqAzionFdCpa1eJ8= X-Gm-Gg: AfdE7clSbCj2ptOITvGprDeasNbMiqqUnvZOXIVqSdJ4u8EBsxr2TkIbhWYKfq2ATV5 5NqQQCT6/2KmlIY9sgT6WpFUCakLtF56ugXDXbTVc3FK5NVPeaWxoj6ue+lJ1StkTVhfpqtUtLg DIeMidk40pvzu9pYVmu8dQfsQYB3E6sJ/NsNjhHSw2YZ57u71SmiwyKuQOQaO8U5CCpi/yYCKN9 j2JpdiTpLXODDmTjKInobffKovIXYEJQzw9RtNz8IPh7u1p2yCXldBfgNBo7DveAdJr3GfVvxNj XHmAwW2bnqf1XINgZdRgWfklnljEAxjNCN1ClWwTsj/XyVQb9FUgRAuTpbHtMWTUdPIGJNLWag8 LHqnB1nMDbJdg+QnagUzodCBtKGyPAm/knNI= X-Received: by 2002:a05:622a:43:b0:50e:6311:7380 with SMTP id d75a77b69052e-51cbf2157c5mr75176241cf.6.1783938880303; Mon, 13 Jul 2026 03:34:40 -0700 (PDT) X-Received: by 2002:a05:622a:43:b0:50e:6311:7380 with SMTP id d75a77b69052e-51cbf2157c5mr75175131cf.6.1783938877229; Mon, 13 Jul 2026 03:34:37 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69a19cd89b1sm14741341a12.1.2026.07.13.03.34.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2026 03:34:35 -0700 (PDT) Message-ID: Date: Mon, 13 Jul 2026 12:34:32 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] i2c: qcom-geni: Use devm_pm_runtime_enable() for PM management To: Mukesh Kumar Savaliya , viken.dadhaniya@oss.qualcomm.com, andi.shyti@kernel.org, linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260713064130.1681130-1-mukesh.savaliya@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260713064130.1681130-1-mukesh.savaliya@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: VQ8649ESD0v6bAmlM5E3fOETmH4YWWRS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEzMDEwOSBTYWx0ZWRfX+6iv678jYuJw FKb2MqfLOYMWgm+oYqLxYohXjcf8ft700MjkUf0ye+Z80FSHh6CCQ3jwF7cpUaNc0n1WbP4O5gF y5hrnM35IdirEeyl/qG6zWJmQeafKnE13qzwUAp4maxjRU5p16G6/jcuv/y0BPCZYu485Eqszq8 RdHg5aryHKjHVHSo23Y2IypzbIPw3V067/1HrKRz3z/Px7h2X3st0JgKk4YMDtEoLIjDwDI+BGu xXO5CAzqMTmPMaNl3RGnAwcnK6LQcYlr9UWZ/GHJL7tN/whDWd7R9ptdlF4tPQyiOuayBfjPzb2 uy3/Z26uiL065y31mg41FBomoqqE8zg58eMuMiCOvOOqsyCwu7CTF2LNbnXr1bPCVgrT9mb4Hsd REXqRPf8wPzwPrxAKf6ZbqjMw0QmupQ3kDQL0jPmyGpybq13kVvOLnsnGUlq+Ii3WKNedkGK5PZ 5y4+phcTnsRKSYF1vQw== X-Proofpoint-GUID: VQ8649ESD0v6bAmlM5E3fOETmH4YWWRS X-Authority-Analysis: v=2.4 cv=AfmB2XXG c=1 sm=1 tr=0 ts=6a54bf41 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=jculsIPVV0WIAI6NCkAA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEzMDEwOSBTYWx0ZWRfXyXHbaiLaLCH2 400pnu9fSWHjQpawvhDzo8IiO0D1QtCI8vw75fPSRGe2nA6lrD4SzRZre1bqfe/BCaPVU07s92o JG0AJzAcwownoUJBaXztO5FjsH8HHYI= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-13_02,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 clxscore=1015 suspectscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607130109 On 7/13/26 8:41 AM, Mukesh Kumar Savaliya wrote: > The current implementation manually calls pm_runtime_enable() in probe() > and pm_runtime_disable() in remove() and error paths. This pattern is > error-prone and requires careful cleanup in all failure paths. Using the > devres-managed variant eliminates this complexity. > > Migrate from manual pm_runtime_enable()/pm_runtime_disable() calls to > the devres-managed devm_pm_runtime_enable() API. This simplifies the > driver by automatically handling runtime PM cleanup when the device is > removed or probe fails. This helps with Simplified error handling and > Automatic cleanup. > > Signed-off-by: Mukesh Kumar Savaliya > --- Reviewed-by: Konrad Dybcio Konrad