From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25EA2C433E2 for ; Mon, 14 Sep 2020 07:56:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC35E20829 for ; Mon, 14 Sep 2020 07:56:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UNTubtzZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726142AbgINH4C (ORCPT ); Mon, 14 Sep 2020 03:56:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726046AbgINHzy (ORCPT ); Mon, 14 Sep 2020 03:55:54 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2132C06174A; Mon, 14 Sep 2020 00:55:53 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id c2so17754171ljj.12; Mon, 14 Sep 2020 00:55:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OLKPHbtOt8z8JIW1cBDEqkvkofIIPjEN7iRAGXlScGQ=; b=UNTubtzZLEL8oapWyD53tB8szukUP0AsmWl7SbBE//kxC0c5XMcjBS6sLBATSDVR0L IuE5QOsKg8Z7ySquYugpz11Rnpjcczw6WLt23YwjdbPhYhE+s8AtwAKd0lmVypuaKUAm WnDbCLuYROjkokJMWl5HQTzaEkHHorc236gPnmWlDu89LOHv4fdV47LNV35Eh/7MHzch GkB/RCzN7Df7uAt3kYFACzQ4EXUcvAGS9JkEOzpuYFOo+ClyR4eO8b2SWveMCzIPTS4t XSGpah8zxJIgzICSppIZO7ur7/HHngsoldfPVNV2D/LXWaQBtOVIiv05AjerqOXxiZ5N paKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=OLKPHbtOt8z8JIW1cBDEqkvkofIIPjEN7iRAGXlScGQ=; b=lAAWy+dWcKcACWSDGUafjQ3FVLOvcF9uEpKyMpvfcvjW1omlx74sKZz62Kwm+9wXKm ty9nWizsl8yukUQ+pbGH0nwWtfolZRoYE5zQrKwwortS04gq/7nJuXhnF9gHIlNYuQfu l9R1sJoX0i79vYWIVsqGAqGrI5gyJ1PYft8uN18XiAL5EaGISYfghcP1RWOOtImvP0Qy y4Y4jEH2rlEUBy0wGebqi5YcudIqGvmjmo7iiXd/Eogbm9dNh6OrsbrfNX04o7Ou4KNI 6vtmygbQEJP0zZ1/yUxeVa6s2qZYnFwfsqH2/eQNhW/9lb/VvmpnNc2HYBFS9SDPEl91 mlaQ== X-Gm-Message-State: AOAM533EpOUyU2WbEOMAE/WioWA6lJpf0Wp7LUip66EUtHGUlzOQY/of 1wzqPubIBtoRdDYH40N6a1f2i6OJ8gE7mw== X-Google-Smtp-Source: ABdhPJw1Eycx1S/HY2dEZIfzRDk6BOovCZSHzkBaMT4r1idgXaFwjQ+i7sxIZUsbExhYOCgFKvCMjg== X-Received: by 2002:a2e:92cd:: with SMTP id k13mr4455424ljh.138.1600070152066; Mon, 14 Sep 2020 00:55:52 -0700 (PDT) Received: from ?IPv6:2a00:1fa0:239:d1e4:b56b:9cf2:d12e:444? ([2a00:1fa0:239:d1e4:b56b:9cf2:d12e:444]) by smtp.gmail.com with ESMTPSA id h16sm3577107lfc.63.2020.09.14.00.55.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Sep 2020 00:55:51 -0700 (PDT) Subject: Re: [PATCH v4 2/3] media: i2c: ov772x: Add support for BT656 mode To: Lad Prabhakar , Jacopo Mondi , Sakari Ailus , Laurent Pinchart , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Biju Das , Prabhakar References: <20200913184247.618-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20200913184247.618-3-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Sergei Shtylyov Organization: Brain-dead Software Message-ID: Date: Mon, 14 Sep 2020 10:55:48 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200913184247.618-3-prabhakar.mahadev-lad.rj@bp.renesas.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 13.09.2020 21:42, Lad Prabhakar wrote: > Add support to read the bus-type for V4L2_MBUS_BT656 and > enable BT656 mode in the sensor if needed. Isn't it called BT.656? > Signed-off-by: Lad Prabhakar > Reviewed-by: Biju Das > --- > drivers/media/i2c/ov772x.c | 27 +++++++++++++++++++++------ > 1 file changed, 21 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c > index 551082aa7026..edd7c4c22225 100644 > --- a/drivers/media/i2c/ov772x.c > +++ b/drivers/media/i2c/ov772x.c [...] > @@ -1427,16 +1434,24 @@ static int ov772x_probe(struct i2c_client *client) > goto error_clk_put; > } > > - bus_cfg.bus_type = V4L2_MBUS_PARALLEL; > + bus_cfg = (struct v4l2_fwnode_endpoint) > + { .bus_type = V4L2_MBUS_BT656 }; > ret = v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg); > priv->bus_type = bus_cfg.bus_type; > v4l2_fwnode_endpoint_free(&bus_cfg); > if (ret) { > - /* For backward compatibility with the existing DT where > - * bus-type isnt specified fallback to V4L2_MBUS_PARALLEL > - */ > - priv->bus_type = V4L2_MBUS_PARALLEL; > - dev_notice(&client->dev, "Falling back to V4L2_MBUS_PARALLEL mode\n"); > + bus_cfg.bus_type = V4L2_MBUS_PARALLEL; > + ret = v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg); > + priv->bus_type = bus_cfg.bus_type; > + v4l2_fwnode_endpoint_free(&bus_cfg); > + if (ret) { > + /* For backward compatibility with the existing DT where > + * bus-type isnt specified fallback to V4L2_MBUS_PARALLEL ^^^^ isn't Could be fixed, while at it? > + */ > + priv->bus_type = V4L2_MBUS_PARALLEL; > + dev_notice(&client->dev, > + "Falling back to V4L2_MBUS_PARALLEL mode\n"); > + } > } > > ret = ov772x_video_probe(priv); MBR, Sergei