From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752149AbdF1Rqi (ORCPT ); Wed, 28 Jun 2017 13:46:38 -0400 Received: from mga01.intel.com ([192.55.52.88]:43298 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751528AbdF1Rqd (ORCPT ); Wed, 28 Jun 2017 13:46:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,276,1496127600"; d="scan'208";a="872690412" Subject: Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events To: Arnaldo Carvalho de Melo Cc: Andi Kleen , linux-kernel@vger.kernel.org References: <1495786658-18063-1-git-send-email-adrian.hunter@intel.com> <1495786658-18063-26-git-send-email-adrian.hunter@intel.com> <20170628130438.GB3342@kernel.org> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Wed, 28 Jun 2017 20:40:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170628130438.GB3342@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/28/2017 04:04 PM, Arnaldo Carvalho de Melo wrote: > Em Fri, May 26, 2017 at 11:17:26AM +0300, Adrian Hunter escreveu: >> Add definitions for synthesized Intel PT events for power and ptwrite. > >> +++ b/tools/perf/util/event.h >> +/* >> + * Raw data formats for synthesized events. Note that raw data plus the raw data >> + * size (4 bytes) must align to 8-bytes. >> + */ >> + >> +struct perf_synth_intel_ptwrite { >> + union { >> + struct { >> + u32 ip : 1, >> + reserved : 31; >> + }; >> + u32 flags; >> + }; >> + u64 payload; >> +} __packed; > > > some versions of clang and gcc dislike this __packed here: > > In file included from builtin-script.c:5: > In file included from /git/linux/tools/perf/util/debug.h:8: > /git/linux/tools/perf/util/event.h:274:2: error: packed attribute is unnecessary for (null) [-Werror,-Wpacked] > union { > ^ > /git/linux/tools/perf/util/event.h:285:6: error: packed attribute is unnecessary for 'reserved' [-Werror,-Wpacked] > u32 reserved; > ^ > /git/linux/tools/perf/util/event.h:298:6: error: packed attribute is unnecessary for 'reserved' [-Werror,-Wpacked] > u32 reserved; > ^ > /git/linux/tools/perf/util/event.h:322:6: error: packed attribute is unnecessary for 'reserved' [-Werror,-Wpacked] > u32 reserved; > ^ > 4 errors generated. > mv: can't rename '/tmp/build/perf/.builtin-script.o.tmp': No such file or directory > > /git/linux/tools/build/Makefile.build:101: recipe for target '/tmp/build/perf/builtin-script.o' failed > > Failing in various distros: > > [root@jouet ~]# waitp 3940 ; time dm > 1 92.3684147260 alpine:3.4: FAIL > 2 95.9136365930 alpine:3.5: FAIL > 3 104.8328303770 alpine:3.6: FAIL > 4 121.6584964930 alpine:edge: FAIL > 5 37.2536373490 android-ndk:r12b-arm: Ok > 6 83.9077612370 archlinux:latest: Ok > 7 14.7094639200 centos:5: FAIL > 8 16.6371634320 centos:6: FAIL > > Investigating... Re-reading the documentation for __packed, it seems like the following might be better: diff --git a/tools/perf/util/event.h b/tools/perf/util/event.h index c283603f59c7..a7547cb3b760 100644 --- a/tools/perf/util/event.h +++ b/tools/perf/util/event.h @@ -278,8 +278,8 @@ struct perf_synth_intel_ptwrite { }; u32 flags; }; - u64 payload; -} __packed; + u64 payload __packed; +}; struct perf_synth_intel_mwait { u32 reserved; @@ -291,8 +291,8 @@ struct perf_synth_intel_mwait { reserved2 : 30; }; u64 payload; - }; -} __packed; + } __packed; +}; struct perf_synth_intel_pwre { u32 reserved; @@ -305,8 +305,8 @@ struct perf_synth_intel_pwre { reserved2 : 48; }; u64 payload; - }; -} __packed; + } __packed; +}; struct perf_synth_intel_exstop { union { @@ -328,8 +328,8 @@ struct perf_synth_intel_pwrx { reserved1 : 52; }; u64 payload; - }; -} __packed; + } __packed; +}; struct perf_synth_intel_cbr { union {