From: Tadeusz Struk <tadeusz.struk@linaro.org>
To: Bryan O'Donoghue <pure.logic@nexus-software.ie>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>,
Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Amit Pundir <amit.pundir@linaro.org>,
John Stultz <john.stultz@linaro.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: venus: Synchronize probe() between venus_core and enc/dec
Date: Mon, 25 Oct 2021 08:30:06 -0700 [thread overview]
Message-ID: <bba3acc1-cfa1-0c53-75de-f4ffa0a2bc9e@linaro.org> (raw)
In-Reply-To: <72f8dd7a-66c7-fb50-db23-f98ba753af1d@nexus-software.ie>
[-- Attachment #1.1: Type: text/plain, Size: 724 bytes --]
Hi Bryan,
On 10/25/21 08:24, Bryan O'Donoghue wrote:
>
>> + struct mutex sync_lock;
>
> Why have an additional mutex, will the existing core::lock not do ?
I wanted to reuse it, but the core::lock in used internally in hfi and
it will deadlock there if we use that one here.
> shouldn't this be an -EPROBE_DEFER i.e. CORE_INIT hasn't completed/run yet so defer until
> it does.
>
> This fragment here looks racy to me without a DEFER above ?
>
> drivers/media/platform/qcom/venus/core.c::venus_probe()
No, we want a hard stop here. At this point the venus_core probe()
has finished and it failed. Returning -EPROBE_DEFER here will just
cause it to loop infinitely.
--
Thanks,
Tadeusz
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2021-10-25 15:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 14:43 Tadeusz Struk
2021-10-25 15:24 ` Bryan O'Donoghue
2021-10-25 15:30 ` Tadeusz Struk [this message]
2021-10-25 16:03 ` Bryan O'Donoghue
2021-10-25 16:17 ` Bryan O'Donoghue
2021-10-25 16:57 ` Tadeusz Struk
2021-10-25 17:17 ` Bryan O'Donoghue
2021-10-25 17:26 ` Tadeusz Struk
2021-10-28 0:01 ` John Stultz
2021-10-28 0:19 ` Tadeusz Struk
2021-10-28 2:36 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bba3acc1-cfa1-0c53-75de-f4ffa0a2bc9e@linaro.org \
--to=tadeusz.struk@linaro.org \
--cc=agross@kernel.org \
--cc=amit.pundir@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=john.stultz@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=pure.logic@nexus-software.ie \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®