From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32FDB422E35 for ; Thu, 6 Aug 2026 21:41:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786052518; cv=none; b=n5GGLZvyDX5TbzYS/oM4J4O65p6mW4rDi2YcRdjQdgEyL83gd6DNd4Cn3y6ezQ/NIE8WUnTe8P9W8v28z+1kCAfjHiM9LwQMJ6B4hHf41AJR5JdtGUIUNFH61scUedrx6L6n3pC7CM4wQctKZulgl83OspGeO9vytL1HWhCins8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786052518; c=relaxed/simple; bh=u4mYCUb7A6vXwqZPeaZnsDxDp6uqmLsrUiKWTgkQhH8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Qxd6w54Ok7D8s8lx5oM86XPo00COKfqfXsQPnuiK2qsKVUSMZsLPdC/3lv/IKLIRjsKXu0w72n3KhgaUaV9tvFNig0cF1Xm/YW3mwKEwb+OO6gHFHjny+KqjcvOKXRYT2AU3h8D1NKxC3GdHGT9l1O1hdrHUzABijMEjut2vNKQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kCy8Ea8J; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kCy8Ea8J" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-ca7c1176317so2395533a12.1 for ; Thu, 06 Aug 2026 14:41:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786052516; x=1786657316; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=8zBZKPK23TfXcgyMB9pk4gFPHhEbEq+i3z/pYrHxDl0=; b=kCy8Ea8JdElBBmnkyvsbv3vtqZ341JwHRWsWv4ojBfKKwBqKjLZd0sp3giv4TUuYvl HcryPAan2FzxtoRM9hoHLaIiR4LI2cTIeMhbo4XbXUnYAumO/+80gMuSQ0Ve3KY7iTFy vTId0eJzpCbcSxAk2rAaX+ykz9lXWl1gfrYTswPUWPPppLNyf5CadjOo9geYbGMRmC4t CKYg1+/k3pgn891t5daKXyZiNWeQuaCvF1KaAzBRNxRdLLXJGSDn0BxHTaC6T4HG3AM9 fjVS/p+O/R4BXpHnpBbeM1DNwi0E4OWG+wiMXenxEwj+Y/Z95SzrJRZSM7Pz/HKSw1jP itQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786052516; x=1786657316; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8zBZKPK23TfXcgyMB9pk4gFPHhEbEq+i3z/pYrHxDl0=; b=NB0oakuHciRBSQn3CuMhOBY1zDEv2dT6FRob1xQFmI847LHNhRGoroJLkHyRWyi7jR l6vERn7GKiFyDU1npYx38ZFVaCph7GXxr3n+HyEey+51TJ0O7UcrkLDnF94i8PM83pJ1 4zImfcjRoLALpdpAdlmut+yD6Dpeij9lbpSvphEHrImBjw0h0RCagwTfnHcXoSsaySmc nfX9xmOQK2Ikddklemhe1xggczlTosoFZy2cW0kPdXwLAysEKLUDjwMh4jovFbT9II7t Kl/RiPV9kmsfKhiI7X7RbktLHFONwNJU7sRJSHvsAL0SvRTs0LvmimE3tYL3xOJvuZwq xsWQ== X-Forwarded-Encrypted: i=1; AHgh+Ro8jBaoVOAZ8Pf8xszdE4SbLRiY4zr6PHXBehZZlJaUXTNMm6BU+5P4Nb3ePva8Ll9qBxVdEgnyV/1tC3s=@vger.kernel.org X-Gm-Message-State: AOJu0Yw69PXA5j1ZFipVkarlbxblnZCwN/lTXmOnlwcKwZnwmnwsxQ09 odnDQ/F2tXDR+vwEhKqKAhOYxfqhKhGprIjh0kgOWJCn4w52UaIFk/6R X-Gm-Gg: AR+sD13EeygmeKrDSGQ7wQw2VzhRSVNM/+aKeGAJBq/NvLpnseU1OLoHgol9xaQ3lbe RdkivalnxcGQ75xGYHSqb3e1Erckrx+XSrOLaNK57Yzt7zrtT7limD7ULCkC7bmfupDxFgdtcdl g/asvwiRPFpvojmYYoupkSnducEeYNh6rpUxV/pysVR3ixdDkraPpWwDnfC1YZbFxqLXElbIvZV Jkc4xe6bkTL5xPoTnsPBhrtONcBDTPdaYdB1SfPXnXjE1yg1JisoGWvgP6MfQisBUwSZLYcQepY goKFPQiJMmBHz+TQTO7Hd/vfRgROLZGP+34A/K+54jClkJHB/2sMHl3mNrCU2eMcxZ6H4f9svag IL3Qybcb7cgZCanHWcC40jhlRe46R4RO949x1CusxUMvqNphjNBV+eJOPOC+UY2Pku7Cg1cUk+W NIr3WArX4Z5jV6uGWa4L1d17uq9ixOM6hBN+uzTCBn+yiZA6z64dJ/NK3OQ6w1uHeJTR566/5jT w== X-Received: by 2002:a05:6a21:1bc1:b0:3c1:c6e:9360 with SMTP id adf61e73a8af0-3cb85f4a60bmr21408761637.32.1786052516422; Thu, 06 Aug 2026 14:41:56 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315bca44c9fsm324948eec.17.2026.08.06.14.41.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 14:41:55 -0700 (PDT) Sender: Guenter Roeck Date: Thu, 6 Aug 2026 14:41:54 -0700 From: Guenter Roeck To: Mayank Rungta Cc: Andrew Morton , Wim Van Sebroeck , Tzung-Bi Shih , Douglas Anderson , linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: Re: [PATCH 2/2] watchdog: pretimeout: Convert dump pretimeout governor to tristate Message-ID: References: <20260730-export-cpu-backtrace-apis-v1-0-bace8e1cb817@google.com> <20260730-export-cpu-backtrace-apis-v1-2-bace8e1cb817@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260730-export-cpu-backtrace-apis-v1-2-bace8e1cb817@google.com> On Thu, Jul 30, 2026 at 03:00:22PM -0700, Mayank Rungta wrote: > From: Mayank Rungta > > Commit 645ad41da8b2 ("watchdog: pretimeout: Add "dump" pretimeout > governor") added the "dump" watchdog pretimeout governor, but restricted > it to built-in code because trigger_all_cpu_backtrace() was not exported > to loadable modules. > > Now that CPU backtrace APIs are supported for loadable kernel modules > via cpumask_backtrace(), convert WATCHDOG_PRETIMEOUT_GOV_DUMP to > tristate. This allows kernels to deliver the pretimeout governor as a > loadable kernel module. > > Signed-off-by: Mayank Rungta > Reviewed-by: Douglas Anderson > Reviewed-by: Tzung-Bi Shih As mentioned in the other patch, I can not apply the series without Ack from a maintainer. In case someone else wants to pick it up instead: Acked-by: Guenter Roeck > --- > drivers/watchdog/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index 9f013d774897..922741dd837c 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -99,8 +99,8 @@ config WATCHDOG_PRETIMEOUT_GOV_SEL > if WATCHDOG_PRETIMEOUT_GOV > > config WATCHDOG_PRETIMEOUT_GOV_DUMP > - bool "Dump watchdog pretimeout governor" > - depends on WATCHDOG_CORE=y > + tristate "Dump watchdog pretimeout governor" > + depends on WATCHDOG_CORE > default WATCHDOG_CORE > help > Dump watchdog pretimeout governor, all cpu backtrace is