From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from m16.mail.126.com (m16.mail.126.com [220.197.31.9]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6438424B253 for ; Sat, 11 Jan 2025 08:02:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736582534; cv=none; b=kMJUkdeq191gJ9ZqQb/rXkzIK1g9LywmRTJJpkwFHpaYOou2kYmaGtqNOVjmjx4nu9wbEFNRLdENtaJNRPIqPXMC5j/bgrgpeR7SL3oXVPY3zFE48eBv2XTpHNdkQlBsuf7Y4lf09hp/VOxStRhKQnI372vhVlDkdNSRqkawfWc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736582534; c=relaxed/simple; bh=1QGkVgSBdu8BX6+oCHd/02Vq8/CjfYXaJdyU+gwcE+0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bvORFmf9+DYxpWgxrKW3YsILf2tMN4cNdFUxGfHrIt65V/98+9NWKH671XNckf9WSnhRxCIQWDFXC1GRJH354ECyDUe4WKHxZVxz2ANdUwKSntJ4G4NFVGXnIlAFM4j4tItTWmSBPRzXXZ136MKNi0LlcAuGCesogyy8K5Xanv8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com; spf=pass smtp.mailfrom=126.com; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b=qHj7BJeS; arc=none smtp.client-ip=220.197.31.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=126.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b="qHj7BJeS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=Message-ID:Date:MIME-Version:Subject:From: Content-Type; bh=c0dwYtbDF1cRnyxKJ4jlux/jd3LTMUlkMyV24OtljCQ=; b=qHj7BJeScxhuh6dU3KTSfH1t39zrhF4J+lW16Afzfb3g3gMh/id/9kCno8JNOj jhFq7W+cz9vGxfqKQPtO0l992kudOZOs0jI0AnqCSJDe70ZEvzahP8jx9ja9EiLR 7yh0+1MED+cJXTV7OxFjK/Y0pTOhDhlI1yyqwD2ntvwqw= Received: from [172.19.20.199] (unknown [112.64.138.194]) by gzsmtp5 (Coremail) with SMTP id qSkvCgB3HG48JYJn4FAODg--.46490S2; Sat, 11 Jan 2025 16:01:00 +0800 (CST) Message-ID: Date: Sat, 11 Jan 2025 16:00:59 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/hugetlb: prevent reuse of isolated free hugepages To: Andrew Morton , David Hildenbrand Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, 21cnbao@gmail.com, baolin.wang@linux.alibaba.com, liuzixing@hygon.cn References: <1736477766-23525-1-git-send-email-yangge1116@126.com> <20250110174541.bf22caf1afa227b9a76a7e4c@linux-foundation.org> From: Ge Yang In-Reply-To: <20250110174541.bf22caf1afa227b9a76a7e4c@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID:qSkvCgB3HG48JYJn4FAODg--.46490S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7XFWrtry7Xw1fAw1UuFWUCFg_yoW8JryUpF y8K3WDKaykJr92kr4aqan0yr1avrsaqFyUXrn8tF9rC390qry5JrWI9w45uw4I9rnagr4Y vr4kuas3ZFn8uFDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07j5sqXUUUUU= X-CM-SenderInfo: 51dqwwjhrrila6rslhhfrp/1tbifgDRG2eCIeMgnwAAss 在 2025/1/11 9:45, Andrew Morton 写道: > On Fri, 10 Jan 2025 09:14:47 +0100 David Hildenbrand wrote: > >>> To migrate huge 0, we obtain huge x from the pool. After the migration >>> is completed, we return the now-freed huge 0 back to the pool. When >>> it's time to migrate huge 1, we can simply reuse the now-freed huge 0 >>> from the pool. As a result, when replace_free_hugepage_folios() is >>> executed, it cannot release huge 0 back to the buddy system. >>> >>> To slove the proble above, we should prevent reuse of isolated free >>> hugepages. >> >> s/slove/solve/ >> s/proble/problem/ >> >>> >>> Link: https://lore.kernel.org/lkml/1734503588-16254-1-git-send-email-yangge1116@126.com/ >>> Fixes: 08d312ee4c0a ("mm: replace free hugepage folios after migration") >> >> The commit id is not stable yet. >> >> $ git tag --contains 08d312ee4c0a >> mm-everything-2025-01-09-06-44 >> next-20250110 >> >> >> We should squash this into the original fix. Can you resend the whole >> thing and merge the patch descriptions? > > I queued this as > replace-free-hugepage-folios-after-migration-fix-3.patch. But yes, a > clean v4 with a redone changelog would be a nice thing to have. ok, thanks.