From: "Paul E. McKenney" <paulmck@kernel.org>
To: Bradley Morgan <brads@mainlining.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
boqun@kernel.org, frederic@kernel.org, include@grrlz.net,
jiangshanlai@gmail.com, joelagnelf@nvidia.com,
josh@joshtriplett.org, linux-kernel@vger.kernel.org,
neeraj.upadhyay@kernel.org, qiang.zhang@linux.dev,
rcu@vger.kernel.org, rostedt@goodmis.org, urezki@gmail.com
Subject: Re: [PATCH] hazptrtorture: Fix inverted sleep condition in do_pending kthread
Date: Sun, 6 Sep 2026 16:16:55 -0700 [thread overview]
Message-ID: <bbab8067-9bb4-46d0-bbbd-da7b836b04f5@paulmck-laptop> (raw)
In-Reply-To: <179E0ECA-C65D-4480-9E4E-CFA960D55665@mainlining.org>
On Sun, Sep 06, 2026 at 07:56:29PM +0100, Bradley Morgan wrote:
> On 6 September 2026 19:46:50 BST, "Paul E. McKenney" <paulmck@kernel.org>
> wrote:
> >On Sun, Sep 06, 2026 at 09:09:53AM -0400, Mathieu Desnoyers wrote:
> >> On 2026-09-05 16:40, Paul E. McKenney wrote:
> >> > On Fri, Sep 04, 2026 at 06:28:45PM +0100, Bradley Morgan wrote:
> >> [...]
> >> > I would not say "no" to a fix for this issue:
> >> >
> >> >
> >https://lore.kernel.org/all/EE579805-42F2-4C58-B752-F28779EEB717@grrlz.net/
> >>
> >> I'm not sure this URL actually points to a relevant issue ?
> >
> >Indeed, it does not, apologies! Here you go:
> >
> >https://lore.kernel.org/all/202608130915.62b53936-lkp@intel.com/
> >
> >> > Once that is in place, I would be happy to put this back into -next.
> >> >
> >> > At some point, we will need to get rid of the concept of wildcard
> >hazard
> >> > pointers, as those end up instead emulating RCU, but I don't see that
> >> > as an immediate obstacle.
> >>
> >> I already have the implementation which eliminates the wildcard if we
> >> care about this. It was part of a previous hazptr series version.
> >>
> >> Do you want me to resurrect it on top of the current series ?
> >> This depends on:
> >>
> >> - ptr_eq(),
> >> - then use ptr_eq() to compare the loaded pointer (pre mb)
> >> with the re-loaded pointer (post-mb).
> >>
> >> See:
> >https://lore.kernel.org/all/20251218014531.3793471-1-mathieu.desnoyers@efficios.com/
> >
> >The main objection was over the content and style of the kernel-doc
> >header comment, right? I am guessing that it should be possible to
> >resolve this to roughly equal disgust of all concerned. ;-)
> >
> >We did make some progress on this sort of pointer issue in C++29
> >this past June:
> >
> >https://people.kernel.org/paulmck/c-pointer-zap-and-oota-progress
> >
> >But the piece you need is this guy, which is still in process:
> >
> >https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2025/p3790r1.pdf
> >
> >Plus it will be some time before this reaches all the compilers used
> >to build the Linux kernel, and probably even more time to reach the
> >C language. I do have pen-on-paper notes that will lead to a draft
> >of the corresponding C-language working paper, but these things do not
> >move quickly.
> >
> >So, yes, we will need something like ptr_eq() for some years to come.
> >
> >Back to your original question, given the fix for the above bug and
> >given the current use case, I believe we can get the current series into
> >mainline. Give or take Linus's thoughts on the matter. But either way,
> >we will need a version that allows the user to avoid all wildcard use
> >sooner rather than later.
> >
> >So having a series on top of the current one for a later merge window
> >would be a very good thing!
> >
> Can I participate in this? :)
If Mathieu is OK with it, feel free to look at the patch stack that
Mathieu sent the URL for earlier in this thread. Either way, please
feel free to look at the stack in my -rcu tree based on v7.3-rc1 and
headed by this commit:
4398b7c192d ("hazptr: Implement two-phase wildcard scan")
Perhaps you can find the bug that kernel test robot located. ;-)
My -rcu tree is here:
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
Just so you know, in all cases, your taking on a task does not preclude
others from also taking that same task on.
Thanx, Paul
> --- Thanks!
> https://lore.kernel.org/all/EE579805-42F2-4C58-B752-F28779EEB717@grrlz.net/
next prev parent reply other threads:[~2026-09-06 23:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 0:03 Bradley Morgan
2026-08-04 3:46 ` Paul E. McKenney
2026-09-04 13:01 ` Mathieu Desnoyers
2026-09-04 16:00 ` Paul E. McKenney
2026-09-04 17:28 ` Bradley Morgan
2026-09-05 20:40 ` Paul E. McKenney
2026-09-05 21:08 ` Bradley Morgan
2026-09-05 22:54 ` Paul E. McKenney
2026-09-06 10:44 ` Bradley Morgan
2026-09-06 13:09 ` Mathieu Desnoyers
2026-09-06 13:20 ` Bradley Morgan
2026-09-06 13:21 ` Bradley Morgan
2026-09-06 18:46 ` Paul E. McKenney
2026-09-06 18:56 ` Bradley Morgan
2026-09-06 23:16 ` Paul E. McKenney [this message]
2026-09-07 18:11 ` Bradley Morgan
2026-09-07 20:18 ` Paul E. McKenney
2026-09-07 20:41 ` Bradley Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbab8067-9bb4-46d0-bbbd-da7b836b04f5@paulmck-laptop \
--to=paulmck@kernel.org \
--cc=boqun@kernel.org \
--cc=brads@mainlining.org \
--cc=frederic@kernel.org \
--cc=include@grrlz.net \
--cc=jiangshanlai@gmail.com \
--cc=joelagnelf@nvidia.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=neeraj.upadhyay@kernel.org \
--cc=qiang.zhang@linux.dev \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®