From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033877AbdAFNFQ (ORCPT ); Fri, 6 Jan 2017 08:05:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45854 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032392AbdAFND5 (ORCPT ); Fri, 6 Jan 2017 08:03:57 -0500 Subject: Re: [PATCH v6 08/18] iommu/vt-d: Implement reserved region get/put callbacks To: Joerg Roedel References: <1483643086-2883-1-git-send-email-eric.auger@redhat.com> <1483643086-2883-9-git-send-email-eric.auger@redhat.com> <20170106110131.GM17255@8bytes.org> <36bac0a9-89a6-ff7b-1870-a795a4f57700@redhat.com> <20170106124631.GP17255@8bytes.org> Cc: eric.auger.pro@gmail.com, christoffer.dall@linaro.org, marc.zyngier@arm.com, robin.murphy@arm.com, alex.williamson@redhat.com, will.deacon@arm.com, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, drjones@redhat.com, linux-kernel@vger.kernel.org, pranav.sawargaonkar@gmail.com, iommu@lists.linux-foundation.org, punit.agrawal@arm.com, diana.craciun@nxp.com, gpkulkarni@gmail.com, shankerd@codeaurora.org, bharat.bhushan@nxp.com, geethasowjanya.akula@gmail.com From: Auger Eric Message-ID: Date: Fri, 6 Jan 2017 14:03:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170106124631.GP17255@8bytes.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 06 Jan 2017 13:03:34 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joerg, On 06/01/2017 13:46, Joerg Roedel wrote: > On Fri, Jan 06, 2017 at 12:45:54PM +0100, Auger Eric wrote: >> On 06/01/2017 12:01, Joerg Roedel wrote: >>> On Thu, Jan 05, 2017 at 07:04:36PM +0000, Eric Auger wrote: > >>> That is different from what AMD does, can you also report the RMRR >>> regions for the device here (as direct-map regions)? >> >> if I return RMRR regions as direct mapped regions, >> iommu_group_create_direct_mappings will perform the 1-1 mapping. > > No, this will not happen until the Intel IOMMU driver returns valid > IOMMU_DOMAIN_DMA type domains. Hum OK thanks! Best Regards Eric > >> I am not familiar with the intel-iommu code but I guess this job >> currently is done in the intel driver: >> iommu_prepare_rmrr_dev -> iommu_prepare_identity_map >> ->domain_prepare_identity_map -> iommu_domain_identity_map? > > Right, this is done in the Intel driver atm. > > > > Joerg >