From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932103AbcGAOQJ (ORCPT ); Fri, 1 Jul 2016 10:16:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43762 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752213AbcGAOQG (ORCPT ); Fri, 1 Jul 2016 10:16:06 -0400 Subject: Re: [PATCH v1 04/11] KVM: x86: use u16 for logical VCPU mask in lapic To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: <20160630205429.16480-1-rkrcmar@redhat.com> <20160630205429.16480-5-rkrcmar@redhat.com> <20160701124759.GB27840@potion> Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, "Lan, Tianyu" , Igor Mammedov , Jan Kiszka , Peter Xu From: Paolo Bonzini Message-ID: Date: Fri, 1 Jul 2016 16:04:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160701124759.GB27840@potion> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 01 Jul 2016 14:04:43 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/07/2016 14:48, Radim Krčmář wrote: > The other callsite in kvm_irq_delivery_to_apic() does not pass 16: > > int idx = kvm_vector_to_index(irq->vector, dest_vcpus, > dest_vcpu_bitmap, KVM_MAX_VCPUS); Ah, missed it. > kvm_vector_to_index() uses find_next_bit(), so we would have two casts > if we changed the type. This patch is not really needed, so I could > drop it instead. Yes, let's leave it aside (and then you don't have to put it before patch 2!). Paolo