From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "Gao, Chao" <chao.gao@intel.com>
Cc: "tglx@kernel.org" <tglx@kernel.org>,
"bp@alien8.de" <bp@alien8.de>, "kas@kernel.org" <kas@kernel.org>,
"yilun.xu@linux.intel.com" <yilun.xu@linux.intel.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"x86@kernel.org" <x86@kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Subject: Re: [RFC PATCH v2 02/10] x86/virt/tdx: Convert the version metadata reader
Date: Thu, 24 Sep 2026 19:53:37 +0000 [thread overview]
Message-ID: <bbae95eb8f510aef404741b56779aff72a3e5439.camel@intel.com> (raw)
In-Reply-To: <arS6D6KoPbqVBtPl@intel.com>
On Thu, 2026-09-24 at 13:50 +0800, Chao Gao wrote:
> > > +#define read_sys_metadata_table(_table, _data) \
> > > + __read_sys_metadata_table(_table, ARRAY_SIZE(_table), _data)
> >
> > Should this go in the previous patch?
>
> I didn't put it there because the previous patch doesn't strictly need
> it; this patch is the first user.
Well the functions in the previous patch doesn't have any callers either...
>
> Adding the macro in the previous patch while still tagging
> __read_sys_metadata_table() __maybe_unused looks a bit odd:
> the macro references the function, yet nothing uses either of them.
Ehh.
>
> That said, I can move it if the oddness doesn't bother you.
I'd move it because it seems inconsistent to put it here.
next prev parent reply other threads:[~2026-09-24 19:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 13:29 [RFC PATCH v2 00/10] TDX: Stop auto-generating the global metadata code Chao Gao
2026-09-18 13:29 ` [RFC PATCH v2 01/10] x86/virt/tdx: Add a helper to read a table of metadata fields Chao Gao
2026-09-23 22:20 ` Edgecombe, Rick P
2026-09-24 5:36 ` Chao Gao
2026-09-24 6:13 ` Binbin Wu
2026-09-18 13:29 ` [RFC PATCH v2 02/10] x86/virt/tdx: Convert the version metadata reader Chao Gao
2026-09-23 22:26 ` Edgecombe, Rick P
2026-09-24 5:50 ` Chao Gao
2026-09-24 19:12 ` Dave Hansen
2026-09-24 19:53 ` Edgecombe, Rick P [this message]
2026-09-24 6:40 ` Binbin Wu
2026-09-18 13:29 ` [RFC PATCH v2 03/10] x86/virt/tdx: Convert the features " Chao Gao
2026-09-18 13:29 ` [RFC PATCH v2 04/10] x86/virt/tdx: Convert the tdmr " Chao Gao
2026-09-18 13:29 ` [RFC PATCH v2 05/10] x86/virt/tdx: Convert the td_ctrl " Chao Gao
2026-09-18 13:29 ` [RFC PATCH v2 06/10] x86/virt/tdx: Convert the handoff " Chao Gao
2026-09-18 13:29 ` [RFC PATCH v2 07/10] x86/virt/tdx: Convert the td_conf " Chao Gao
2026-09-18 13:29 ` [RFC PATCH v2 08/10] x86/virt/tdx: Remove tdx_global_metadata.c Chao Gao
2026-09-23 22:53 ` Edgecombe, Rick P
2026-09-18 13:29 ` [RFC PATCH v2 09/10] x86/virt/tdx: Use early returns in get_tdx_sys_info() Chao Gao
2026-09-23 22:52 ` Edgecombe, Rick P
2026-09-24 7:28 ` Chao Gao
2026-09-18 13:29 ` [RFC PATCH v2 10/10] x86/virt/tdx: Verify structure member sizes against metadata field IDs Chao Gao
2026-09-23 22:47 ` Edgecombe, Rick P
2026-09-24 7:20 ` Chao Gao
2026-09-23 0:47 ` [RFC PATCH v2 00/10] TDX: Stop auto-generating the global metadata code Edgecombe, Rick P
2026-09-23 8:23 ` Chao Gao
2026-09-23 5:44 ` Tony Lindgren
2026-09-23 8:19 ` Chao Gao
2026-09-23 8:37 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbae95eb8f510aef404741b56779aff72a3e5439.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=bp@alien8.de \
--cc=chao.gao@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kas@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=yilun.xu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®