From: Javier Martinez Canillas <javierm@redhat.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux Fbdev development list" <linux-fbdev@vger.kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Sam Ravnborg" <sam@ravnborg.org>,
"DRI Development" <dri-devel@lists.freedesktop.org>,
"Maxime Ripard" <maxime@cerno.tech>,
"Noralf Trønnes" <noralf@tronnes.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@linux.ie>,
"Lee Jones" <lee.jones@linaro.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Linux PWM List" <linux-pwm@vger.kernel.org>
Subject: Re: [PATCH v6 3/6] drm: Add driver for Solomon SSD130x OLED displays
Date: Wed, 9 Mar 2022 14:43:14 +0100 [thread overview]
Message-ID: <bbb4f088-e6f8-52b6-c673-6e30583cbe57@redhat.com> (raw)
In-Reply-To: <CAMuHMdUVWKee+Wm=EP49=5TAgqodPsMjkC2MHUfnyBDF_zt_Zg@mail.gmail.com>
Hello Geert,
On 3/9/22 13:56, Geert Uytterhoeven wrote:
> Hi Javier,
>
> On Wed, Mar 9, 2022 at 1:14 PM Javier Martinez Canillas
> <javierm@redhat.com> wrote:
>> On 3/8/22 17:30, Geert Uytterhoeven wrote:
>>> Unfortunately a regression was introduced since your v3: printed
>>> text is mirrored upside-down. I.e. "E" is rendered correctly, but "L"
>>> turns into "Γ" (Greek Gamma).
>>> I suspect something went wrong with the display initialization
>>> sequence.
>>>
>>
>> Could you please try Chen-Yu's fix for the COM scan direction mask ?
>>
>> https://lists.freedesktop.org/archives/dri-devel/2022-March/345915.html
>>
>> I made a mistake when converting to use the GENMASK() and FIELD_PREP()
>> macros in v4 as suggested by Andy. The SSD130X_SET_COM_SCAN_DIR_MASK
>> wasn't correct which would explain the output to be vertically flipped.
>
> Thanks, confirmed fixed.
>
Great, thanks a lot for testing and the confirmation!
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-03-09 13:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 13:37 [PATCH v6 0/6] " Javier Martinez Canillas
2022-02-14 13:37 ` [PATCH v6 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line() Javier Martinez Canillas
2022-02-16 9:16 ` Maxime Ripard
2022-02-14 13:37 ` [PATCH v6 2/6] drm/format-helper: Add drm_fb_xrgb8888_to_mono_reversed() Javier Martinez Canillas
2022-02-16 9:16 ` Maxime Ripard
2022-03-08 16:13 ` Geert Uytterhoeven
2022-03-09 12:03 ` Javier Martinez Canillas
2022-02-14 13:37 ` [PATCH v6 3/6] drm: Add driver for Solomon SSD130x OLED displays Javier Martinez Canillas
2022-02-16 9:16 ` Maxime Ripard
2022-03-08 16:30 ` Geert Uytterhoeven
2022-03-09 12:14 ` Javier Martinez Canillas
2022-03-09 12:56 ` Geert Uytterhoeven
2022-03-09 13:43 ` Javier Martinez Canillas [this message]
2022-03-09 20:04 ` Geert Uytterhoeven
2022-03-09 20:13 ` Javier Martinez Canillas
2022-02-14 13:37 ` [PATCH v6 4/6] drm/solomon: Add SSD130x OLED displays I2C support Javier Martinez Canillas
2022-02-16 9:17 ` Maxime Ripard
2022-02-14 13:39 ` [PATCH v6 5/6] MAINTAINERS: Add entry for Solomon SSD130x OLED displays DRM driver Javier Martinez Canillas
2022-02-16 9:17 ` Maxime Ripard
2022-02-14 13:39 ` [PATCH v6 6/6] dt-bindings: display: ssd1307fb: Add myself as binding co-maintainer Javier Martinez Canillas
2022-02-16 9:17 ` Maxime Ripard
2022-02-16 12:34 ` [PATCH v6 0/6] drm: Add driver for Solomon SSD130x OLED displays Javier Martinez Canillas
2022-03-10 13:11 [PATCH v6 3/6] " Dominik Kierner
2022-05-25 19:46 ` Javier Martinez Canillas
2022-06-01 16:58 ` andriy.shevchenko
2022-06-13 11:39 Dominik Kierner
2022-06-13 15:35 ` andriy.shevchenko
2022-06-13 17:41 ` Javier Martinez Canillas
2022-06-13 18:17 ` Javier Martinez Canillas
2022-06-14 14:05 Dominik Kierner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbb4f088-e6f8-52b6-c673-6e30583cbe57@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@linux.ie \
--cc=andriy.shevchenko@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=mripard@kernel.org \
--cc=noralf@tronnes.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome