From: "Arnd Bergmann" <arnd@arndb.de>
To: zhangjiao2 <zhangjiao2@cmss.chinamobile.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] char: misc: add missing #ifdef CONFIG_PROC_FS and error checking
Date: Mon, 29 Jul 2024 11:42:37 +0200 [thread overview]
Message-ID: <bbb597df-5bd8-487a-8b5c-9118814632e8@app.fastmail.com> (raw)
In-Reply-To: <20240729073511.61935-1-zhangjiao2@cmss.chinamobile.com>
On Mon, Jul 29, 2024, at 09:35, zhangjiao2 wrote:
> From: Zhang Jiao <zhangjiao2@cmss.chinamobile.com>
>
> Add "#ifdef CONFIG_PROC_FS" to control misc proc create
> and give some error checking.
>
> Signed-off-by: Zhang Jiao <zhangjiao2@cmss.chinamobile.com>
> ---
I don't think this is an improvement: proc_create_*() already
prints a warning about how exactly it went wrong when it does,
and it can usually just continue without it. However, failing
misc_init() is likely to prevent the system from booting.
Arnd
next prev parent reply other threads:[~2024-07-29 9:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 7:35 zhangjiao2
2024-07-29 9:42 ` Arnd Bergmann [this message]
2024-07-30 8:03 ` [PATCH v2] char: misc: add missing #ifdef CONFIG_PROC_FS zhangjiao2
2024-07-30 8:42 ` Greg KH
2024-07-30 8:31 ` zhangjiao2
2024-07-30 9:11 ` Greg KH
2024-07-30 10:25 ` Arnd Bergmann
2024-07-29 9:43 ` [PATCH] char: misc: add missing #ifdef CONFIG_PROC_FS and error checking Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbb597df-5bd8-487a-8b5c-9118814632e8@app.fastmail.com \
--to=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=zhangjiao2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®