mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maulik Shah <maulik.shah@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>,
	Mark Brown <broonie@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v2 1/2] soc: qcom: rpmh-rsc: Update CMD_MSGID_LEN to 4 bytes for read request
Date: Wed, 7 Oct 2026 15:22:52 +0530	[thread overview]
Message-ID: <bbb59b91-c3a0-444f-a902-79a43fa0dd7a@oss.qualcomm.com> (raw)
In-Reply-To: <ltg543gynh5obljyqbtnpn3mnbdpmrazttblzpuvugoshqcdrw@dxksbmbtnyyi>



On 05-10-2026 12:40, Dmitry Baryshkov wrote:
> On Mon, Oct 05, 2026 at 12:30:21PM +0530, Mukesh Ojha wrote:
>> On Fri, Sep 11, 2026 at 02:38:13PM +0530, Maulik Shah wrote:
>>> Newer SoC like hawi with RSC version v4.5 support 4 byte message read
>>> request instead of default 8 byte on older SoCs. The write request
>>> continues to be 8 bytes.
>>>
>>> The CMD_MSGID_LEN field is [3:0] bits. Describe the length bits as a
>>> GENMASK() and use FIELD_PREP() when programming 4-byte or 8-byte message
>>> length.
>>>
>>> Tested-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com> #Hawi
>>> Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
>> I know LPC is going to start today, but I wanted to highlight this patch
>> specifically, as without it, both Hawi and Maili SoC do not boot up at all.
>>
>> Can this be picked up as an independent patch for 7.4 as conveyed in the
>> cover letter?
> You've sent two patches in the same series. Typically maintainers prefer
> to pick all or nothing. Also, Fixes should come before the actual
> changes.

Let me drop patch-2 and send only patch-1 in v3.
patch-2 may wait for some more comments as per [1] before merging in as fixes.

[1] https://lore.kernel.org/lkml/53ea0718-285e-4e81-8f95-76e9b0c0f6af@oss.qualcomm.com/ 

Thanks,
Maulik

  reply	other threads:[~2026-10-07  9:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11  9:08 [PATCH v2 0/2] soc: qcom: rpmh-rsc: Updates for RPMh read requests Maulik Shah
2026-09-11  9:08 ` [PATCH v2 1/2] soc: qcom: rpmh-rsc: Update CMD_MSGID_LEN to 4 bytes for read request Maulik Shah
2026-10-05  7:00   ` Mukesh Ojha
2026-10-05  7:10     ` Dmitry Baryshkov
2026-10-07  9:52       ` Maulik Shah [this message]
2026-09-11  9:08 ` [PATCH v2 2/2] soc: qcom: rpmh-rsc: Skip read requests on unsupported platforms Maulik Shah
2026-09-21 14:29   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bbb59b91-c3a0-444f-a902-79a43fa0dd7a@oss.qualcomm.com \
    --to=maulik.shah@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=broonie@kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=kamal.wadhwa@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mukesh.ojha@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®