From: Rong Chen <rong.a.chen@intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
kernel test robot <lkp@intel.com>
Cc: Saravanan Sekar <sravanhome@gmail.com>,
kbuild-all@lists.01.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Sebastian Reichel <sebastian.reichel@collabora.com>
Subject: Re: [kbuild-all] Re: drivers/power/supply/mp2629_charger.c:522:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
Date: Mon, 12 Oct 2020 13:35:40 +0800 [thread overview]
Message-ID: <bbb89cb9-ce1b-6863-dcc5-c27ba9c05819@intel.com> (raw)
In-Reply-To: <CAHp75VdX_uxbrkX=XF11WDBcuXjpQYWjjOzVzJ8ffj46oGw_JA@mail.gmail.com>
On 10/9/20 10:27 PM, Andy Shevchenko wrote:
> On Fri, Oct 9, 2020 at 4:23 PM kernel test robot <lkp@intel.com> wrote:
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head: 549738f15da0e5a00275977623be199fbbf7df50
>> commit: 3bc6d790c39dfc4539c36525e6bcb617abbae467 power: supply: Add support for mps mp2629 battery charger
>> date: 4 months ago
>> :::::: branch date: 12 hours ago
>> :::::: commit date: 4 months ago
>> compiler: sh4-linux-gcc (GCC) 9.3.0
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
> ...
>
>> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 514 unsigned int rval;
>> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 515 int ret;
>> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 516
>> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 517 ret = regmap_read(charger->regmap, MP2629_REG_IMPEDANCE_COMP, &rval);
>> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 518 if (ret)
>> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 519 return ret;
>> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 520
>> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 521 rval = (rval >> 4) * 10;
>> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 @522 return sprintf(buf, "%d mohm\n", rval);
>> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 523 }
> Right, should be %u. Can LKP generate this type of patches?
>
Hi Andy,
Thanks for the advice, is there a auto correct tool to do such thing?
I afraid we can't cover all the circumstances.
Best Regards,
Rong Chen
prev parent reply other threads:[~2020-10-12 5:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 13:37 kernel test robot
2020-10-09 14:27 ` Andy Shevchenko
2020-10-12 5:35 ` Rong Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbb89cb9-ce1b-6863-dcc5-c27ba9c05819@intel.com \
--to=rong.a.chen@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=sebastian.reichel@collabora.com \
--cc=sravanhome@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®