From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B05D42C3261 for ; Thu, 7 May 2026 15:36:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168190; cv=none; b=skTKpiIVVaOzhJYH9fWgAe6wQ21uNHRziJRbH35NZmP4zw1qSYSVV85M4NHwi06O+O+eoZawfN+1Pb6Epq10rmnwDzHWoXGUvc4MRuxt3Beeyp/EdkNE7poc/TRbnYqQyGYv802P9BALl2+5h0ApaG8auxvPCMD1heoBxkzCaqA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168190; c=relaxed/simple; bh=2W8dYdfwEhewnGtptK97U6Aw1UW1pk1NLjT1Cr5YoDw=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=YpRNa/inzXnTV3RR3ErAeMcmIbDEjIhJ5k1pJxMH0YbGnuvgwhvvloV2pskHuQRdvgS8rSYyNpoKkjZjq2GAyhMwHoFGm/oFPzTplQV3cVbhp+fqylXAgreQBYTngUO3O+lf3fEzrkLp9YVpc+MUQDN2puqLuTHkNG5wk1xTh5I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cPdEQhCI; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cPdEQhCI" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-48a3e9862f0so7064015e9.1 for ; Thu, 07 May 2026 08:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778168187; x=1778772987; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=BOJ+8+8n014/ZZxYvTpXNz4gBXn6E+/f1gXcWqpdrZs=; b=cPdEQhCI2iT0k59r1p7NDelfmyFEkqk7Asw/1MrDkJj8vC4EyIU0uYbsdbA18PC3tO nxy6zupAKAKd/VC8Md5U+VS7hn2MgXoKDY+9T6JRqUu3HWSv+5vM9EjtK2RxO7lConW1 bZGt1mJfj2g9jBfd9nDhViFU2dfXYRpnAwBwkE8iOATOyvI+9mEdNB8g+V0Vml/leyL+ 2N/OKvWPN3FoWwcQYs5aQWmFPU09Ob2+gsEotEz36wNXEkIB/UsQ1CmZypIKJL6gPJ5Y PN3FN8He7OlfcGcePocwT1ZC1EJDgQrx7AhsXHavFkzJCab/l1yFl/1xBlNUd8fDxsDU 23hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778168187; x=1778772987; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BOJ+8+8n014/ZZxYvTpXNz4gBXn6E+/f1gXcWqpdrZs=; b=df6oGpWgTMVBN6U/1+zlwiEDCM5Fv0CleP6/PxwyH1rapBZtS4FnnaBVFvVx8Jrs82 qVvPiZmqUqN6R+UisheJW1eWx5hb64F8ysqpW1cZZuM9Vn4EMfp/k+py2ZW2FuYhBnMj PoRCJWCVBqKljW9TX1/6KpJ7ToulhxGKsyTMeSgJWv81ZnMxmV4ZQ+RivdnfQzM0IY5Q 5e2Xl+yDtJ/k2ubj3kQzFO4kLwYdvqmL+zvziTuIE42M23iZD8HBOgBi4+zH2U5imOfU BNVkDpI8/xkvDI39yFNecfGVzNZKXA18dWmEg/CujrwZGDJgV/TjSb1KZ9JwiCGewyyV +seA== X-Forwarded-Encrypted: i=1; AFNElJ/6NZ/56MpLuXDjnJRuzkW+htFgt/SbSPVSm4WIZEYouDGJruvlETZh2z5yoxzzDMa2wqfSFnsVBPhcO0Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7JHtgaMiHlnQaJuAYOMgbdRnDWNRIplHK7CfeNCPrKt2I16Oh J7Y6sCXBlS/aBtLg5Ib7I5v9m4+D3/nH62Hncnnt/TIH8GzKj9UaX7XlLsqYfuTuZkdx5A8c1g3 sgCcF X-Gm-Gg: AeBDieuqprZUMMKNVGI3xLXZxw9On6A7Xm+yty+Srj2/w9BAUjzJ4Qh39qXreC00grO FzwMTa0M1flzKaE9qF5UJoslbWoHuRkJOKPCTGX+N6WUGDozTwlDTk8IB/Zqxr8qcT8+HF+Sz0B qSfG+fGfgxPNk2gUlTAI8AOC7NyXruLISgkWQ7zTMGEWH7U/7/cyoVkh213qgXuVQXEbQkOw1Ox NwjI+RaE24vK3NTrphvmjOZymFaP0kqL43ZhEbZzgi/6+KsroTnTN/mjlraTAqdQB3tCPObdtzC tuJz2dxFgKZNPqz3hzhZLoS/xlheHzbw/edNfL7z118M5ylqIu9zVl7CSFPoJeEFktS+e4v5fHB N5up9fOvVbqWjBkP1QCXIaIAGQYn18C6SGxJ8HzP9np4/Zbd//NARck4bUeHZXQBfk0xn7+o/Cu 641YocIJbQ4AFpkVVKV0m9AYaT/we2WCAoZSw0vecIEy/MygrCV4eyvEKCyqHO1lVIB/vZjLgh5 QBzC3QZjDHqCBdbAA== X-Received: by 2002:a05:600c:3e10:b0:485:3cef:d6ea with SMTP id 5b1f17b1804b1-48e5e0089e0mr57342345e9.13.1778168186924; Thu, 07 May 2026 08:36:26 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:6762:47bb:1e06:ff70? ([2a01:e0a:106d:1080:6762:47bb:1e06:ff70]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e5312dbf8sm40556895e9.23.2026.05.07.08.36.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 08:36:26 -0700 (PDT) Message-ID: Date: Thu, 7 May 2026 17:36:24 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 06/10] drm/panel/tdo-tl070wsh30: Use refcounted allocation in place of devm_kzalloc() To: Albert Esteve , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Michael Tretter , Michael Walle , Dario Binacchi Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260507-drm_panel_init_rm-v1-0-51f448c7c291@redhat.com> <20260507-drm_panel_init_rm-v1-6-51f448c7c291@redhat.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260507-drm_panel_init_rm-v1-6-51f448c7c291@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/7/26 13:53, Albert Esteve wrote: > Move to using the new API devm_drm_panel_alloc() to allocate the > panel. In the call to the new API, avoid using explicit type and use > __typeof() for more type safety. > > Signed-off-by: Albert Esteve > --- > drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c b/drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c > index 227f97f9b136f..13cfe252a838d 100644 > --- a/drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c > +++ b/drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c > @@ -162,9 +162,6 @@ static int tdo_tl070wsh30_panel_add(struct tdo_tl070wsh30_panel *tdo_tl070wsh30) > return err; > } > > - drm_panel_init(&tdo_tl070wsh30->base, &tdo_tl070wsh30->link->dev, > - &tdo_tl070wsh30_panel_funcs, DRM_MODE_CONNECTOR_DSI); > - > err = drm_panel_of_backlight(&tdo_tl070wsh30->base); > if (err) > return err; > @@ -183,10 +180,13 @@ static int tdo_tl070wsh30_panel_probe(struct mipi_dsi_device *dsi) > dsi->format = MIPI_DSI_FMT_RGB888; > dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | MIPI_DSI_MODE_LPM; > > - tdo_tl070wsh30 = devm_kzalloc(&dsi->dev, sizeof(*tdo_tl070wsh30), > - GFP_KERNEL); > - if (!tdo_tl070wsh30) > - return -ENOMEM; > + tdo_tl070wsh30 = devm_drm_panel_alloc(&dsi->dev, > + __typeof(*tdo_tl070wsh30), base, > + &tdo_tl070wsh30_panel_funcs, > + DRM_MODE_CONNECTOR_DSI); > + > + if (IS_ERR(tdo_tl070wsh30)) > + return PTR_ERR(tdo_tl070wsh30); > > mipi_dsi_set_drvdata(dsi, tdo_tl070wsh30); > tdo_tl070wsh30->link = dsi; > Reviewed-by: Neil Armstrong Thanks, Neil