From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C76B9C433E0 for ; Wed, 1 Jul 2020 02:31:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A6C1D2073E for ; Wed, 1 Jul 2020 02:31:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726810AbgGACbt (ORCPT ); Tue, 30 Jun 2020 22:31:49 -0400 Received: from mga03.intel.com ([134.134.136.65]:20501 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725988AbgGACbs (ORCPT ); Tue, 30 Jun 2020 22:31:48 -0400 IronPort-SDR: O12L8JU+MZMpp7tsmDUoPt3cZEvPpwh9Q/VneiuO3N/K0XsdxkJzds03T76sGZA7GSX1QJgf5B BXw8EG5lyxug== X-IronPort-AV: E=McAfee;i="6000,8403,9668"; a="146439855" X-IronPort-AV: E=Sophos;i="5.75,298,1589266800"; d="scan'208";a="146439855" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2020 19:31:47 -0700 IronPort-SDR: hueeM/Xkc1UeeVZCt3X7WtSxlqWhu3CrnIFVzc/QUvObfntkVQzWdJz4sL0ASrt2tcRdKlpK1R z/Iq4S+VBoSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,298,1589266800"; d="scan'208";a="265275739" Received: from allen-box.sh.intel.com (HELO [10.239.159.139]) ([10.239.159.139]) by fmsmga007.fm.intel.com with ESMTP; 30 Jun 2020 19:31:45 -0700 Cc: baolu.lu@linux.intel.com, Joerg Roedel , Jacob Pan , "Raj, Ashok" , "Liu, Yi L" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 3/4] iommu/vt-d: Report page request faults for guest SVA To: "Tian, Kevin" , "iommu@lists.linux-foundation.org" References: <20200628003332.5720-1-baolu.lu@linux.intel.com> <20200628003332.5720-4-baolu.lu@linux.intel.com> From: Lu Baolu Message-ID: Date: Wed, 1 Jul 2020 10:27:22 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kevin, Thanks a lot for reviewing my patches. On 6/30/20 2:01 PM, Tian, Kevin wrote: >> From: Lu Baolu >> Sent: Sunday, June 28, 2020 8:34 AM >> >> A pasid might be bound to a page table from a VM guest via the iommu >> ops.sva_bind_gpasid. In this case, when a DMA page fault is detected >> on the physical IOMMU, we need to inject the page fault request into >> the guest. After the guest completes handling the page fault, a page >> response need to be sent back via the iommu ops.page_response(). >> >> This adds support to report a page request fault. Any external module >> which is interested in handling this fault should regiester a notifier >> callback. >> >> Co-developed-by: Jacob Pan >> Signed-off-by: Jacob Pan >> Co-developed-by: Liu Yi L >> Signed-off-by: Liu Yi L >> Signed-off-by: Lu Baolu >> --- >> drivers/iommu/intel/svm.c | 83 >> +++++++++++++++++++++++++++++++++++++-- >> 1 file changed, 80 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c >> index c23167877b2b..4800bb6f8794 100644 >> --- a/drivers/iommu/intel/svm.c >> +++ b/drivers/iommu/intel/svm.c >> @@ -815,6 +815,69 @@ static void intel_svm_drain_prq(struct device *dev, >> int pasid) >> } >> } >> >> +static int prq_to_iommu_prot(struct page_req_dsc *req) >> +{ >> + int prot = 0; >> + >> + if (req->rd_req) >> + prot |= IOMMU_FAULT_PERM_READ; >> + if (req->wr_req) >> + prot |= IOMMU_FAULT_PERM_WRITE; >> + if (req->exe_req) >> + prot |= IOMMU_FAULT_PERM_EXEC; >> + if (req->pm_req) >> + prot |= IOMMU_FAULT_PERM_PRIV; >> + >> + return prot; >> +} >> + >> +static int >> +intel_svm_prq_report(struct intel_iommu *iommu, struct page_req_dsc >> *desc) >> +{ >> + struct iommu_fault_event event; >> + struct pci_dev *pdev; >> + u8 bus, devfn; >> + int ret = 0; >> + >> + memset(&event, 0, sizeof(struct iommu_fault_event)); >> + bus = PCI_BUS_NUM(desc->rid); >> + devfn = desc->rid & 0xff; >> + pdev = pci_get_domain_bus_and_slot(iommu->segment, bus, devfn); > > Is this step necessary? dev can be passed in (based on sdev), and more > importantly iommu_report_device_fault already handles the ref counting > e.g. get_device(dev) when fault handler is valid... Yes, agreed. I will pass device in instead. > >> + >> + if (!pdev) { >> + pr_err("No PCI device found for PRQ [%02x:%02x.%d]\n", >> + bus, PCI_SLOT(devfn), PCI_FUNC(devfn)); >> + return -ENODEV; >> + } >> + >> + /* Fill in event data for device specific processing */ >> + event.fault.type = IOMMU_FAULT_PAGE_REQ; >> + event.fault.prm.addr = desc->addr; >> + event.fault.prm.pasid = desc->pasid; >> + event.fault.prm.grpid = desc->prg_index; >> + event.fault.prm.perm = prq_to_iommu_prot(desc); >> + >> + /* >> + * Set last page in group bit if private data is present, >> + * page response is required as it does for LPIG. >> + */ >> + if (desc->lpig) >> + event.fault.prm.flags |= >> IOMMU_FAULT_PAGE_REQUEST_LAST_PAGE; >> + if (desc->pasid_present) >> + event.fault.prm.flags |= >> IOMMU_FAULT_PAGE_REQUEST_PASID_VALID; >> + if (desc->priv_data_present) { >> + event.fault.prm.flags |= >> IOMMU_FAULT_PAGE_REQUEST_LAST_PAGE; > > why setting lpig under this condition? /* * Per VT-d spec. v3.0 ch7.7, system software must * respond with page group response if private data * is present (PDP) or last page in group (LPIG) bit * is set. This is an additional VT-d feature beyond * PCI ATS spec. */ > >> + event.fault.prm.flags |= >> IOMMU_FAULT_PAGE_REQUEST_PRIV_DATA; >> + memcpy(event.fault.prm.private_data, desc->priv_data, >> + sizeof(desc->priv_data)); >> + } >> + >> + ret = iommu_report_device_fault(&pdev->dev, &event); >> + pci_dev_put(pdev); >> + >> + return ret; >> +} >> + >> static irqreturn_t prq_event_thread(int irq, void *d) >> { >> struct intel_iommu *iommu = d; >> @@ -874,6 +937,19 @@ static irqreturn_t prq_event_thread(int irq, void *d) >> if (!is_canonical_address(address)) >> goto bad_req; >> >> + /* >> + * If prq is to be handled outside iommu driver via receiver of >> + * the fault notifiers, we skip the page response here. >> + */ >> + if (svm->flags & SVM_FLAG_GUEST_MODE) { >> + int res = intel_svm_prq_report(iommu, req); >> + >> + if (!res) >> + goto prq_advance; >> + else >> + goto bad_req; >> + } >> + > > I noted in bad_req there is another reporting logic: > > if (sdev && sdev->ops && sdev->ops->fault_cb) { > int rwxp = (req->rd_req << 3) | (req->wr_req << 2) | > (req->exe_req << 1) | (req->pm_req); > sdev->ops->fault_cb(sdev->dev, req->pasid, req->addr, > req->priv_data, rwxp, result); > } > > It was introduced in the 1st version of svm.c. It might be unrelated to > this patch, but I wonder whether that one should be replaced with > iommu_report_device_fault too? This call back will be deprecated. The previous api in generic iommu has been removed. https://www.spinics.net/lists/iommu/msg43657.html I will make it in a separated patch. > > Thanks > Kevin Best regards, baolu > >> /* If the mm is already defunct, don't handle faults. */ >> if (!mmget_not_zero(svm->mm)) >> goto bad_req; >> @@ -892,10 +968,10 @@ static irqreturn_t prq_event_thread(int irq, void *d) >> goto invalid; >> >> result = QI_RESP_SUCCESS; >> - invalid: >> +invalid: >> mmap_read_unlock(svm->mm); >> mmput(svm->mm); >> - bad_req: >> +bad_req: >> /* Accounting for major/minor faults? */ >> rcu_read_lock(); >> list_for_each_entry_rcu(sdev, &svm->devs, list) { >> @@ -920,7 +996,7 @@ static irqreturn_t prq_event_thread(int irq, void *d) >> and these can be NULL. Do not use them below this point! >> */ >> sdev = NULL; >> svm = NULL; >> - no_pasid: >> +no_pasid: >> if (req->lpig || req->priv_data_present) { >> /* >> * Per VT-d spec. v3.0 ch7.7, system software must >> @@ -945,6 +1021,7 @@ static irqreturn_t prq_event_thread(int irq, void *d) >> resp.qw3 = 0; >> qi_submit_sync(iommu, &resp, 1, 0); >> } >> +prq_advance: >> head = (head + sizeof(*req)) & PRQ_RING_MASK; >> } >> >> -- >> 2.17.1 >