From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753347AbdHQS4G (ORCPT ); Thu, 17 Aug 2017 14:56:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45560 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752236AbdHQS4F (ORCPT ); Thu, 17 Aug 2017 14:56:05 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8A39278EA8 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=longman@redhat.com Subject: Re: [PATCH v2 1/2] cgroup: Add a hint to allow v1 controller to use v2 behavior To: Tejun Heo Cc: Li Zefan , Johannes Weiner , linux-kernel@vger.kernel.org References: <1502994339-21668-1-git-send-email-longman@redhat.com> <1502994339-21668-2-git-send-email-longman@redhat.com> <20170817184844.GB491396@devbig577.frc2.facebook.com> From: Waiman Long Organization: Red Hat Message-ID: Date: Thu, 17 Aug 2017 14:56:03 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20170817184844.GB491396@devbig577.frc2.facebook.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 17 Aug 2017 18:56:05 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/17/2017 02:48 PM, Tejun Heo wrote: > Hello, Waiman. > > On Thu, Aug 17, 2017 at 02:25:38PM -0400, Waiman Long wrote: >> For some cgroup controllers, the behavior on cgroup v1 differs somewhat >> from cgroup v2. To indicate that a controller can use v2 behavior >> in cgroup v1, a new cgroupfs mount option "v2_mode" is added. This >> is essentially a hint, there is no obligation for a controller to >> comply with this semantics. > Heh, I don't think we can make it a generic flag. We can't have one > kernel interpreting the option one way and later kernels doing > differently. Let's just make it cpuset specific - something like > cpuset_v2_mode. > > Thanks. > That is fine for me. I will update the patchset accordingly. Thanks, Longman