From: "Christian König" <christian.koenig@amd.com>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Harry Wentland <harry.wentland@amd.com>,
Charlene Liu <charlene.liu@amd.com>
Cc: Leo Li <sunpeng.li@amd.com>,
Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Alvin Lee <alvin.lee2@amd.com>, Wenjing Liu <wenjing.liu@amd.com>,
Jun Lei <jun.lei@amd.com>, Tom Chung <chiahsuan.chung@amd.com>,
Dillon Varone <dillon.varone@amd.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm/amd/display: re-indent dc_power_down_on_boot()
Date: Wed, 24 Apr 2024 15:11:08 +0200 [thread overview]
Message-ID: <bbc315ed-3482-4abb-b3f6-88c335dcf9d2@amd.com> (raw)
In-Reply-To: <e5f538ab-ebc8-400b-8104-4642b8089b4f@moroto.mountain>
Am 24.04.24 um 13:41 schrieb Dan Carpenter:
> These lines are indented too far. Clean the whitespace.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 8eefba757da4..f64d7229eb6c 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -5043,11 +5043,10 @@ void dc_interrupt_ack(struct dc *dc, enum dc_irq_source src)
> void dc_power_down_on_boot(struct dc *dc)
> {
> if (dc->ctx->dce_environment != DCE_ENV_VIRTUAL_HW &&
> - dc->hwss.power_down_on_boot) {
> -
> - if (dc->caps.ips_support)
> - dc_exit_ips_for_hw_access(dc);
> + dc->hwss.power_down_on_boot) {
>
> + if (dc->caps.ips_support)
> + dc_exit_ips_for_hw_access(dc);
Well while at it can't the two ifs be merged here?
(I don't know this code to well, but it looks like it).
Regards,
Christian.
> dc->hwss.power_down_on_boot(dc);
> }
> }
next prev parent reply other threads:[~2024-04-24 13:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 11:41 Dan Carpenter
2024-04-24 13:11 ` Christian König [this message]
2024-04-24 13:20 ` Dan Carpenter
2024-04-24 13:33 ` Christian König
2024-04-24 13:39 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbc315ed-3482-4abb-b3f6-88c335dcf9d2@amd.com \
--to=christian.koenig@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=alvin.lee2@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=charlene.liu@amd.com \
--cc=chiahsuan.chung@amd.com \
--cc=dan.carpenter@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dillon.varone@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=jun.lei@amd.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sunpeng.li@amd.com \
--cc=wenjing.liu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®