From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Ryan McCann <quic_rmccann@quicinc.com>,
Rob Clark <robdclark@gmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: Rob Clark <robdclark@chromium.org>,
<linux-arm-msm@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<freedreno@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<quic_jesszhan@quicinc.com>
Subject: Re: [PATCH v5 6/6] drm/msm/dpu: Update dev core dump to dump registers of sub-blocks
Date: Fri, 7 Jul 2023 18:58:31 -0700 [thread overview]
Message-ID: <bbcf0b87-f41d-e34d-0821-4ad69016131d@quicinc.com> (raw)
In-Reply-To: <20230622-devcoredump_patch-v5-6-67e8b66c4723@quicinc.com>
On 7/7/2023 6:24 PM, Ryan McCann wrote:
> Currently, the device core dump mechanism does not dump registers of
> sub-blocks within the DSPP, SSPP, DSC, and PINGPONG blocks. Edit
> dpu_kms_mdp_snapshot function to account for sub-blocks.
>
> Signed-off-by: Ryan McCann <quic_rmccann@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 66 +++++++++++++++++++++++++++------
> 1 file changed, 54 insertions(+), 12 deletions(-)
>
Overall, I like this one.
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
next prev parent reply other threads:[~2023-07-08 1:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-08 1:24 [PATCH v5 0/6] Add support to print sub-block registers in dpu hw catalog Ryan McCann
2023-07-08 1:24 ` [PATCH v5 1/6] drm/msm: Update dev core dump to not print backwards Ryan McCann
2023-07-08 1:24 ` [PATCH v5 2/6] drm/msm/dpu: Drop unused num argument from relevant macros Ryan McCann
2023-07-08 1:24 ` [PATCH v5 3/6] drm/msm/dpu: Define names for unnamed sblks Ryan McCann
2023-07-08 1:24 ` [PATCH v5 4/6] drm/msm/dpu: Remove redundant prefix/suffix in name of sub-blocks Ryan McCann
2023-07-08 1:24 ` [PATCH v5 5/6] drm/msm/dpu: Refactor printing of main blocks in device core dump Ryan McCann
2023-07-08 1:53 ` Abhinav Kumar
2023-07-08 1:54 ` Dmitry Baryshkov
2023-07-08 1:24 ` [PATCH v5 6/6] drm/msm/dpu: Update dev core dump to dump registers of sub-blocks Ryan McCann
2023-07-08 1:57 ` Dmitry Baryshkov
2023-07-08 1:58 ` Abhinav Kumar [this message]
2023-07-08 1:59 ` [PATCH v5 0/6] Add support to print sub-block registers in dpu hw catalog Abhinav Kumar
2023-07-11 14:21 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbcf0b87-f41d-e34d-0821-4ad69016131d@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_jesszhan@quicinc.com \
--cc=quic_rmccann@quicinc.com \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®