mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
Cc: pavan.chebbi@broadcom.com, mchan@broadcom.com,
	andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
	lszubowi@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] tg3: Add PowerEdge R740xd to AER quirk list
Date: Mon, 6 Apr 2026 01:49:12 +0200	[thread overview]
Message-ID: <bbd6d9df-9698-41d3-808b-c751bc1c4576@lunn.ch> (raw)
In-Reply-To: <CAJioSGcBb3eRtgQXHWx+Bhw4M422dyAo-0yXO-XwU7h4hmwmEQ@mail.gmail.com>

On Sun, Apr 05, 2026 at 12:56:11PM +0200, Oskar Ray-Frayssinet wrote:
> On Sun, Apr 05, 2026 at 01:03:00AM +0200, Andrew Lunn wrote:
> > When you look at tg3_restart_aer_quirk_table[] they are all Dell.
> > Are there any Dell systems which actually work? Would it make sense
> > to mark all Dell systems as broken and enable the quirk?
> 
> That's a good point. I don't know if there are Dell systems where
> the quirk would cause harm. Do you know if it's safe to apply the
> quirk to all Dell systems, or should we be cautious and keep the
> per-model approach?

You might want to ask on the PCI list.

As far as i see, with 30 seconds for searching and reading
documentation, AER, Advanced Error Reporting is an optional feature of
PCIe. Since it is optional, it seems like disabling it during shutdown
should not have any negative effects. Except for systems where it
actually works, and there are real errors during shutdown and
resume. It will be harder to debug such errors since you don't get the
advanced error report.

      Andrew

      reply	other threads:[~2026-04-05 23:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-04 22:50 Oskar Ray-Frayssinet
2026-04-04 23:03 ` Andrew Lunn
2026-04-05 10:56   ` Oskar Ray-Frayssinet
2026-04-05 23:49     ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bbd6d9df-9698-41d3-808b-c751bc1c4576@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lszubowi@redhat.com \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavan.chebbi@broadcom.com \
    --cc=rayfraytech@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®