From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E2A13451AE for ; Wed, 17 Sep 2025 09:55:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758102914; cv=none; b=bQmuJ5HVc2qeCZam72fkeJqYI7YKc95qo6QSHtlklMEC/XbSLdpUsuwCbgkEsZaCIuTqVpJVqMIt31CoUsMLDT4Bw2LQEAGFpP8xbrZyqi1eodTuiZ5lLKJ/CjRLcFy1699nZLg6bYr2Uu+q9xAyu7KHU90XI1CnFAtOJtrNEmk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758102914; c=relaxed/simple; bh=djdcQorHSJm5xluKvogCGQhjuFm525QfJ/2Px6pqFWM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OGYxxBsyOAgG4lKYQi1TQ+x7B6aTNsFh7eKVErKmTwg2pViY9tFDyMRVh6CVWB2zbBa7qc/ZfPsX4DUbGy+tckM10gtwOPE+z+oV8jXVcqB30+7V2lLq0K7FeCeXQnGw4+mWzbINMlluekPeBYKJqtmDjuc7xB0A3HHye/2dO/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=SY14dfm7; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=CMxk7EMV; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=SY14dfm7; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=CMxk7EMV; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="SY14dfm7"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="CMxk7EMV"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="SY14dfm7"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="CMxk7EMV" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8A5AE220F2; Wed, 17 Sep 2025 09:55:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1758102910; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jDMDJ1YRYJ021yCvgShr7WT3fYONkSGJfo3wVVSz2Pk=; b=SY14dfm7OHlvUPij+l2PSHFHiu1atOnGFXcD7b4612B7JbbgmC9tJ8TnYwJaCG75maIbGh Gz1JctR1j9E5RSq8bWoZY+fUrHml3gtirnZMn52Lskg7dFqIEx6FHHc6CPTncylMMhggM8 nBiUujMOkb3F0hTI27HKjjD5kw8T1Gw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1758102910; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jDMDJ1YRYJ021yCvgShr7WT3fYONkSGJfo3wVVSz2Pk=; b=CMxk7EMVqabWgrnVYbfOUd5rFE1oMOjZ2PpM7CG5EY4YpFp4LVRCZ+ODTchVZYsJLkpJV0 kXoQegng0ii/UaDw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=SY14dfm7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CMxk7EMV DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1758102910; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jDMDJ1YRYJ021yCvgShr7WT3fYONkSGJfo3wVVSz2Pk=; b=SY14dfm7OHlvUPij+l2PSHFHiu1atOnGFXcD7b4612B7JbbgmC9tJ8TnYwJaCG75maIbGh Gz1JctR1j9E5RSq8bWoZY+fUrHml3gtirnZMn52Lskg7dFqIEx6FHHc6CPTncylMMhggM8 nBiUujMOkb3F0hTI27HKjjD5kw8T1Gw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1758102910; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jDMDJ1YRYJ021yCvgShr7WT3fYONkSGJfo3wVVSz2Pk=; b=CMxk7EMVqabWgrnVYbfOUd5rFE1oMOjZ2PpM7CG5EY4YpFp4LVRCZ+ODTchVZYsJLkpJV0 kXoQegng0ii/UaDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6FB55137C3; Wed, 17 Sep 2025 09:55:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id w3avGn6Fymj0KQAAD6G6ig (envelope-from ); Wed, 17 Sep 2025 09:55:10 +0000 Message-ID: Date: Wed, 17 Sep 2025 11:55:10 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 04/23] slab: add sheaf support for batching kfree_rcu() operations Content-Language: en-US To: Harry Yoo Cc: Suren Baghdasaryan , "Liam R. Howlett" , Christoph Lameter , David Rientjes , Roman Gushchin , Uladzislau Rezki , Sidhartha Kumar , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org, maple-tree@lists.infradead.org References: <20250910-slub-percpu-caches-v8-0-ca3099d8352c@suse.cz> <20250910-slub-percpu-caches-v8-4-ca3099d8352c@suse.cz> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FUZZY_RATELIMITED(0.00)[rspamd.com]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[12]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_CC(0.00)[google.com,oracle.com,gentwo.org,linux.dev,gmail.com,kvack.org,vger.kernel.org,lists.infradead.org]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.cz:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:mid,suse.cz:dkim] X-Spam-Flag: NO X-Spam-Level: X-Rspamd-Queue-Id: 8A5AE220F2 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spam-Score: -4.51 On 9/17/25 10:30, Harry Yoo wrote: > On Wed, Sep 10, 2025 at 10:01:06AM +0200, Vlastimil Babka wrote: >> +/* needed for kvfree_rcu_barrier() */ >> +void flush_all_rcu_sheaves() >> +{ >> + struct slub_percpu_sheaves *pcs; >> + struct slub_flush_work *sfw; >> + struct kmem_cache *s; >> + bool flushed = false; >> + unsigned int cpu; >> + >> + cpus_read_lock(); >> + mutex_lock(&slab_mutex); >> + >> + list_for_each_entry(s, &slab_caches, list) { >> + if (!s->cpu_sheaves) >> + continue; >> + >> + mutex_lock(&flush_lock); >> + >> + for_each_online_cpu(cpu) { >> + sfw = &per_cpu(slub_flush, cpu); >> + pcs = per_cpu_ptr(s->cpu_sheaves, cpu); >> + >> + if (!pcs->rcu_free || !pcs->rcu_free->size) { > > Is the compiler allowed to compile this to read pcs->rcu_free twice? > Something like: > > flush_all_rcu_sheaves() __kfree_rcu_sheaf() > > pcs->rcu_free != NULL > pcs->rcu_free = NULL > pcs->rcu_free == NULL > /* NULL-pointer-deref */ > pcs->rcu_free->size Good point, I'll remove the size check and simply pcs->rcu_free non-null means we flush. >> + sfw->skip = true; >> + continue; >> + } >> >> + INIT_WORK(&sfw->work, flush_rcu_sheaf); >> + sfw->skip = false; >> + sfw->s = s; >> + queue_work_on(cpu, flushwq, &sfw->work); >> + flushed = true; >> + } >> + >> + for_each_online_cpu(cpu) { >> + sfw = &per_cpu(slub_flush, cpu); >> + if (sfw->skip) >> + continue; >> + flush_work(&sfw->work); >> + } >> + >> + mutex_unlock(&flush_lock); >> + } >> + >> + mutex_unlock(&slab_mutex); >> + cpus_read_unlock(); >> + >> + if (flushed) >> + rcu_barrier(); > > I think we need to call rcu_barrier() even if flushed == false? > > Maybe a kvfree_rcu()'d object was already waiting for the rcu callback to > be processed before flush_all_rcu_sheaves() is called, and > in flush_all_rcu_sheaves() we skipped all (cache, cpu) pairs, > so flushed == false but the rcu callback isn't processed yet > by the end of the function? > > That sounds like a very unlikely to happen in a realistic scenario, > but still possible... Yes also good point, will flush unconditionally. Maybe in __kfree_rcu_sheaf() I should also move the call_rcu(...) before local_unlock(). So we don't end up seeing a NULL pcs->rcu_free in flush_all_rcu_sheaves() because __kfree_rcu_sheaf() already set it to NULL, but didn't yet do the call_rcu() as it got preempted after local_unlock(). But then rcu_barrier() itself probably won't mean we make sure such cpus finished the local_locked section, if we didn't queue work on them. So maybe we need synchronize_rcu()?