From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C1F6364933 for ; Thu, 18 Jun 2026 09:19:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781774370; cv=none; b=RyUnkKvIrIscW+HpSHdWxYwg5U1D0B/B9H0ozwqQBPyHVYmr9PabP2tB0JuPS6S7G+eUe7L0ux0i/ImXkJwtD3WX0DIkVQiWk7/YHJovMK+F+ZpwNbbvoCdx5lENeE3eXuJ/3b79YrrE7wB+mOhzVWGsRS9eLKaiwbHPMUA7saU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781774370; c=relaxed/simple; bh=fgWJ/+87MOid3M1d2KnUPab7AXCBQy11iCqSaaEbGsI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OtL8LDqO49TrzKjXP0xnCooeCdN3gynSGArOkF93dBXSe/c0buKxWSKvPJYCNa6x9rwgvSVw47LeNd6mAOzkMG8qdf33TFq3A1JgAL819fTIvCWu/CaLn6lBjzmlN1jxqB38BjZaKwgzdXM2un2jfxWDnEIx9RJsN3ap/H0dCVM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=K5/9KXST; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OqSq7PXo; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="K5/9KXST"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OqSq7PXo" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65I8FPam1177674 for ; Thu, 18 Jun 2026 09:19:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BCppw5saOM5VodB6jl5v2xnwLEdEl/ypS18lhiNEjQc=; b=K5/9KXSTc7aqcWsx LmApMB3soKR1wm/NTVERol101kTx3TD1iVnm7w9ajkCzavFLMKPdl5CqZxE+JYQk yDlYjdfKlMZ4DSzwzhZklwHn4vHd3+HDxPd5JdQfsYb2u11x4rlQ3yTMuvEphzXR pwpPZMY3ny9Yivxwfl3v68qDvXbjHwmjxj4oyP89N1rnMWbhX60sJVrNncGx7o7y Mrg+1DBGnZ1EKeg4ZPijLuB2y4GmFtRMgZcKmeJPZ68V5bG+XxNn247ChJO2Li9j YW2E5zBPKlLohnXb+Vt5upJLurowh6ppzgS/ab+i8dTUTR6+7pf6U8WjbFZ0iKGH 4BTSFQ== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ev12kjsad-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 18 Jun 2026 09:19:28 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-84540760dc9so779109b3a.0 for ; Thu, 18 Jun 2026 02:19:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781774367; x=1782379167; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BCppw5saOM5VodB6jl5v2xnwLEdEl/ypS18lhiNEjQc=; b=OqSq7PXoFDV/su2efUxj6Nz93nS0/7UJF4nkemigw4UAFjKrk9yF72FtH3jwC4j4VD oAXY3vgNU5KeS2fwE3Q37fUp6G99ri8qcSaDTuiXl9wB5fMUR7UMsVhXgp1Z87ZQybIW IDcWHRwekiBDwPZg/h6KcMEZRo2kGgbifiKRY0pTf44ES0nVoOFZVNZ1rEfUBTbKDzby QTo+mqzgbhGFvXLkY/NaUHlW0XurCnahbULIKn80nnSSl+4GRB7WAebbAn9iSgbdDv89 YUmIJ6pkZTsrAgoXBea2bK9JwGBgr3fNrJVs/RYm1D4i2jMELHWl/IdeLmmd3cKINiT3 q3XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781774367; x=1782379167; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BCppw5saOM5VodB6jl5v2xnwLEdEl/ypS18lhiNEjQc=; b=CQ2NP8mTkwgMjgRHmngD4kez2VNqm07wR+s3wU0F7BL05dKeoixaoUMIXvwUFnNcwd qZeeaRaqC8jnj0HaOH2oEKyuz6B/PKeyCPS71onQskCRsMkVqLEir26vJARm3PPh0ohD pQ/VB2DsXNg6bYZfSAj89StYI0aX2IZpMc9+ULovHmnVRFlIsitZQaoeoPth10Num8Tx hImeLpbpJ59uJTerQlTecZq4XSJm2sbvKdlZAVZwIbztXHg08+0Y6FtPKFH7/aDs/BYS lDyoMc5ePiZtNesEUBOfg2xr6uR+uPH5+u4l/n1MAaPVokq6n7zUM69+TdsaqcFn+cLE gI1g== X-Forwarded-Encrypted: i=1; AFNElJ8L5NZXs16GfzNFlCtsXr9LWxUcn6BX7NYg3LmnH29U6kMcPo1eBbaU0CvyHfg1goSv3+2Jrtdpjz5VGHA=@vger.kernel.org X-Gm-Message-State: AOJu0YxuVf8URcsWtJjHKyqeq8G4HCNMJR7lKBvai5YxQm0J8cHB8jek 56xbcVtqMS1Vn/VF8Dco0CBL8yGuA23NRtiFvXdJTJERB4R6gDmvJmsXbSMed7+3XNoI85Ynqa6 K+HwIdcuK8TqnhggZZ1Sqdf/aMmsMZBzJAwvJXZxEleTfvnR2LpFI1+kwXBs5oz5lmFg= X-Gm-Gg: Acq92OG8kzCgD87iATDe/HhZpU0m9BGdQHdr4H9O87N+a3eOE24kv/iB59oWi9Jt98Z wmFEvcqglZMxvvubSDpS+IqU2GwkmqC4HPh1lIwvjI/gmhP7D3oMcC6Pv4Op4feRetg+VcWQwEu QVocjID5tyWLv6Xf89FqzIwEO/UPsWWqynGEUY/ve50CY4j71ZF+6CPXlXQCpfCdycLP9YVhmuB 9cbNSI/akYxu21RAJipVrDefFBE7XwM5UoQWlKhNr7JSdDtnl9DJipJ5td5fYUCd/ZXhwZhuKLt Sc7Zvchb2pWht5tDdkOX5GoaXi1HVHOb8XvQFVO35XPwe1ZDH9qp6qCbxxLLbrAU8Y+iYoPiPDH zhj9qm2TJg41fWfgEzpk+bqduxwTeEzGpc17q3rBUfx5LjcYwRgPswE0Y+/3+YwFS2fAr9ZoWm9 OmzQPhzw== X-Received: by 2002:a05:6a00:3a10:b0:842:5564:2e2a with SMTP id d2e1a72fcca58-8452442f49bmr7847089b3a.6.1781774367155; Thu, 18 Jun 2026 02:19:27 -0700 (PDT) X-Received: by 2002:a05:6a00:3a10:b0:842:5564:2e2a with SMTP id d2e1a72fcca58-8452442f49bmr7847058b3a.6.1781774366684; Thu, 18 Jun 2026 02:19:26 -0700 (PDT) Received: from [10.133.33.90] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434b00d4f5sm18512374b3a.43.2026.06.18.02.19.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2026 02:19:26 -0700 (PDT) Message-ID: Date: Thu, 18 Jun 2026 17:19:23 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ath-next 3/5] wifi: ath12k: add HAL ops for monitor TLV header decode and alignment To: Vasanthakumar Thiagarajan , jjohnson@kernel.org Cc: ath12k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260509025819.1641630-1-miaoqing.pan@oss.qualcomm.com> <20260509025819.1641630-4-miaoqing.pan@oss.qualcomm.com> Content-Language: en-US From: Miaoqing Pan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE4MDA4NiBTYWx0ZWRfX9jIOqcL45EVs MYW5T2V3xWeUW3/4S07GTKMaCQcdQRR1pWf7YA9jix7oOsbibq8BicXauekbx7exD/O6n571SIL laGMq8iFwYbWorQ56pK6GzmLEN0DChlLA7TlZ5OQ9Xc1akE5Ng4uJFazYEOcE2jFJjyBXknPza+ lekcrK+LfhaRssnCjT/WeYoLmd/sTftkcEZ+79M+i0NzpJ3AVm/WgyAmCxDNToI/2rQfvO638h/ A4rWTdSBOYtrL+eSGqZHcVHBp0/vNDGOs+XPGZssthfQ1FPpmsGYlOjhN5tC23QUKGx8V2PvN7H Eeqlh103znPrZNsSZsQz8WwJxvJblHv2hoe48/gjjHK/E3BZ7B+kFXDyDzTmaRa/ytNytNE4NoM ZlxTFT1xtjXWczpuykqSUL32lp89yifP8vhbAq33qDjS2kjYXhtN8DoI2OVPl59z/Md1GRmmCvi SPRxjqAbvmMgdsPhdCA== X-Proofpoint-GUID: 2xdDFBeeJcx7DHKJp0JcxdN-h-EboOce X-Authority-Analysis: v=2.4 cv=HpVG3UTS c=1 sm=1 tr=0 ts=6a33b820 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=qWpXrtrtBgBgn8a_gTkA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-ORIG-GUID: 2xdDFBeeJcx7DHKJp0JcxdN-h-EboOce X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE4MDA4NiBTYWx0ZWRfX2QaOjeSPHzQs p4k5v3YQt/7EMw/np6yxF7NJiLwGWOTcXpw1vTFA6Wh5lBz1Ah6/okDqPwah5mR7yhXeZKpDtrA RXIk3I+CQ894YBBO4kDDc/9lKgdGbZs= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-18_01,2026-06-17_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 adultscore=0 phishscore=0 bulkscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606180086 On 6/18/2026 5:13 PM, Vasanthakumar Thiagarajan wrote: > ops get_tlv_hdr_align() seems unused, may be patch 4/5 is supposed to > used this ops instead of removing the alignment? Used in patch 4/5: @@ -2973,39 +2975,38 @@ ath12k_wifi7_dp_mon_parse_rx_dest(struct ath12k_pdev_dp *dp_pdev, struct sk_buff *skb) { struct ath12k *ar = ath12k_pdev_dp_to_ar(dp_pdev); - struct hal_tlv_64_hdr *tlv; + struct ath12k_hal *hal = &ar->ab->hal; + u8 *tlv_value, *tlv = skb->data; struct ath12k_skb_rxcb *rxcb; enum hal_rx_mon_status hal_status; u16 tlv_tag, tlv_len; - u8 *ptr = skb->data; + u32 tlv_hdr_len; + + tlv_hdr_len = hal->ops->get_tlv_hdr_align();