From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754096AbdEHUZI (ORCPT ); Mon, 8 May 2017 16:25:08 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36439 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752370AbdEHUZG (ORCPT ); Mon, 8 May 2017 16:25:06 -0400 Subject: Re: [PATCH 1/3] leds: Replace flags bit shift with BIT() macros To: David Lin , corbet@lwn.net, rpurdie@rpsys.net, pavel@ucw.cz, hdegoede@redhat.com, mark.rutland@arm.com, tony.makkiel@daqri.com, linz@li-pro.net References: <20170430213701.12297-1-dtwlin@google.com> <20170430213701.12297-2-dtwlin@google.com> Cc: robh@kernel.org, romlem@google.com, joelaf@google.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org From: Jacek Anaszewski X-Enigmail-Draft-Status: N1110 Message-ID: Date: Mon, 8 May 2017 22:24:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170430213701.12297-2-dtwlin@google.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, On 04/30/2017 11:36 PM, David Lin wrote: > This is for readability as well as to avoid checkpatch warnings when > adding new bit flag information in the future. > > Signed-off-by: David Lin > --- > include/linux/leds.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/include/linux/leds.h b/include/linux/leds.h > index 64c56d454f7d..f9d10a9efcbe 100644 > --- a/include/linux/leds.h > +++ b/include/linux/leds.h > @@ -43,12 +43,12 @@ struct led_classdev { > #define LED_SUSPENDED (1 << 0) > #define LED_UNREGISTERING (1 << 1) Could we update also these bits? > /* Upper 16 bits reflect control information */ > -#define LED_CORE_SUSPENDRESUME (1 << 16) > -#define LED_SYSFS_DISABLE (1 << 17) > -#define LED_DEV_CAP_FLASH (1 << 18) > -#define LED_HW_PLUGGABLE (1 << 19) > -#define LED_PANIC_INDICATOR (1 << 20) > -#define LED_BRIGHT_HW_CHANGED (1 << 21) > +#define LED_CORE_SUSPENDRESUME BIT(16) > +#define LED_SYSFS_DISABLE BIT(17) > +#define LED_DEV_CAP_FLASH BIT(18) > +#define LED_HW_PLUGGABLE BIT(19) > +#define LED_PANIC_INDICATOR BIT(20) > +#define LED_BRIGHT_HW_CHANGED BIT(21) > > /* set_brightness_work / blink_timer flags, atomic, private. */ > unsigned long work_flags; > -- Best regards, Jacek Anaszewski