From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DEC4C4332F for ; Thu, 17 Nov 2022 16:33:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240559AbiKQQd0 (ORCPT ); Thu, 17 Nov 2022 11:33:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240512AbiKQQdE (ORCPT ); Thu, 17 Nov 2022 11:33:04 -0500 Received: from mail.3ffe.de (0001.3ffe.de [IPv6:2a01:4f8:c0c:9d57::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7452C82204; Thu, 17 Nov 2022 08:30:31 -0800 (PST) Received: from 3ffe.de (0001.3ffe.de [IPv6:2a01:4f8:c0c:9d57::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.3ffe.de (Postfix) with ESMTPSA id A7DE984; Thu, 17 Nov 2022 17:30:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2022082101; t=1668702629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bRUKljahZwvTGsaOsNNcvH3faXTDENWxWJxvCIKAQJo=; b=1RrZUfw1mQ6RN4Z60F1UKGjIiA9GiZd1LypTS3hZ2rKxxjtDe+ilhbZdi5fjMlnDIkooRd Iiim0xa0HCZSfR2aykoYVmFZgtCGHSTJ36Bez/14p0Lkl5Pw5T4SszUTT83JFZFXf2HShu w92/VQslLqsW+I6SepLf9FTIEIdvV5OZ4HEsZv0OavL8NSLeyL9inaU0nGhk2hCuiTXEfO 6Ci8JfOPPUbzQwUaCxEsR57RqjSEc4RAIU+64HYfzgjOAKqPJmwGtSGr1uWQSelmd6+kdI MBN7SB9Tg/9AsQHl5WUg8OKaOKoc12SDNKqzNNVSRxzrQp7rG/sK7WNDGgKbaw== MIME-Version: 1.0 Date: Thu, 17 Nov 2022 17:30:29 +0100 From: Michael Walle To: Mark Brown Cc: William Breathitt Gray , linus.walleij@linaro.org, brgl@bgdev.pl, andriy.shevchenko@linux.intel.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] gpio: i8255: Migrate to regmap API In-Reply-To: References: <61327a67cc308af413471a69a4810b2785e53e8e.1668129763.git.william.gray@linaro.org> <5123090e11da67e57fb00984445ece2f@walle.cc> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: michael@walle.cc Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2022-11-17 17:21, schrieb Mark Brown: > On Thu, Nov 17, 2022 at 05:18:55PM +0100, Michael Walle wrote: >> Am 2022-11-11 02:55, schrieb William Breathitt Gray: > >> > + gpio_config.parent = config->parent; >> > + gpio_config.regmap = config->map; > >> I'd propose to add a new config flag to indicate that accesses to >> the device will be fast: > >> gpio_config.regmap_has_fast_io = true; > >> which will then set gpio->can_sleep = false. > > It's probably useful to provide a query function in the regmap > API for generic regmap users like this. Now I'm confused. Last time, I've proposed that, there was push back from you: https://lore.kernel.org/linux-gpio/20210430151908.GC5981@sirena.org.uk/ That being said, I'd prefer to have such a query API :) -michael