mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeedm@mellanox.com>
To: "peter_hong@fintek.com.tw" <peter_hong@fintek.com.tw>,
	"wg@grandegger.com" <wg@grandegger.com>,
	"mkl@pengutronix.de" <mkl@pengutronix.de>,
	"hpeter@gmail.com" <hpeter@gmail.com>
Cc: "hpeter+linux_kernel@gmail.com" <hpeter+linux_kernel@gmail.com>,
	"f.suligoi@asem.it" <f.suligoi@asem.it>,
	"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH V2 1/1] can: sja1000: f81601: add Fintek F81601 support
Date: Wed, 24 Jul 2019 19:46:45 +0000	[thread overview]
Message-ID: <bbe907bf7fa1ebe1adfd6bdc9887e4c41ff624bd.camel@mellanox.com> (raw)
In-Reply-To: <37a8be8d-3ce7-e983-93da-35413cfb5da1@gmail.com>

On Wed, 2019-07-24 at 13:19 +0800, Ji-Ze Hong (Peter Hong) wrote:
> Hi,
> 
> Saeed Mahameed 於 2019/7/24 上午 05:38 寫道:
> > On Mon, 2019-07-22 at 14:22 +0800, Ji-Ze Hong (Peter Hong) wrote:
> > > This patch add support for Fintek PCIE to 2 CAN controller
> > > support
> > > 
> > > Signed-off-by: Ji-Ze Hong (Peter Hong) <
> > > hpeter+linux_kernel@gmail.com
> > > ---
> > > Changelog:
> > > v2:
> > > 	1: Fix comment on the spinlock with write access.
> > > 	2: Use ARRAY_SIZE instead of F81601_PCI_MAX_CHAN.
> > > 	3: Check the strap pin outside the loop.
> > > 	4: Fix the cleanup issue in f81601_pci_add_card().
> > > 	5: Remove unused "channels" in struct f81601_pci_card.
> > > 
> > >   drivers/net/can/sja1000/Kconfig  |   8 ++
> > >   drivers/net/can/sja1000/Makefile |   1 +
> > >   drivers/net/can/sja1000/f81601.c | 215
> > > 

[...] 

> > > 
> > > +	/* Detect available channels */
> > > +	for (i = 0; i < count; i++) {
> > > +		dev = alloc_sja1000dev(0);
> > > +		if (!dev) {
> > > +			err = -ENOMEM;
> > > +			goto failure_cleanup;
> > > +		}
> > > +
> > 
> > don't you need to rollback and cleanup/unregister previously
> > allocated
> > devs ?
> > 
> 
> I'll do cleanup when errors jump to failure_cleanup label and do
> f81601_pci_del_card().
> 

Right !, thanks for the clarification. 

      reply	other threads:[~2019-07-24 19:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-22  6:22 Ji-Ze Hong (Peter Hong)
2019-07-22  8:15 ` Marc Kleine-Budde
2019-07-22  8:36   ` Ji-Ze Hong (Peter Hong)
2019-07-22  9:11     ` Marc Kleine-Budde
2019-07-22  9:45 ` Marc Kleine-Budde
2019-07-23 21:38 ` Saeed Mahameed
2019-07-24  5:19   ` Ji-Ze Hong (Peter Hong)
2019-07-24 19:46     ` Saeed Mahameed [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bbe907bf7fa1ebe1adfd6bdc9887e4c41ff624bd.camel@mellanox.com \
    --to=saeedm@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=f.suligoi@asem.it \
    --cc=hpeter+linux_kernel@gmail.com \
    --cc=hpeter@gmail.com \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=peter_hong@fintek.com.tw \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®