From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750989AbdK3W0m (ORCPT ); Thu, 30 Nov 2017 17:26:42 -0500 Received: from ale.deltatee.com ([207.54.116.67]:50126 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750760AbdK3W0l (ORCPT ); Thu, 30 Nov 2017 17:26:41 -0500 To: Serge Semin Cc: jdmason@kudzu.us, dave.jiang@intel.com, Allen.Hubbe@emc.com, Shyam-sundar.S-k@amd.com, Xiangliang.Yu@amd.com, Sergey.Semin@t-platforms.ru, linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org References: <20171130214300.21298-1-fancer.lancer@gmail.com> <923625e8-f071-c9f6-a3e2-c16480d4aea6@deltatee.com> <20171130221258.GA20562@mobilestation> From: Logan Gunthorpe Message-ID: Date: Thu, 30 Nov 2017 15:26:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171130221258.GA20562@mobilestation> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com, Sergey.Semin@t-platforms.ru, Xiangliang.Yu@amd.com, Shyam-sundar.S-k@amd.com, Allen.Hubbe@emc.com, dave.jiang@intel.com, jdmason@kudzu.us, fancer.lancer@gmail.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH 01/08] NTB: ntb_test: Safely use paths with whitespace X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/11/17 03:12 PM, Serge Semin wrote: > In general the intention of the patchset was to update the ntb_test.sh script > so one would be compatible with new NTB test drivers I've also sent. It was > asked of me by the NTB core maintainers. Sorry for not mentioning it in the > cover letter. I understand that. But most importantly a series needs to say what it's based off of and given than it clearly depends on the ntb_tool changes (which I saw later) it was a bit confusing. I think this should be in the same series as the ntb_tool changes as the ntb_test changes depend on ntb_tool and we shouldn't merge the ntb_tool changes without the ntb_test changes as it would break them. Logan