mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>, Radim Krcmar <rkrcmar@redhat.com>
Cc: Eduardo Valentin <eduval@amazon.com>,
	Matt Wilson <msw@amazon.com>, Jonathan Corbet <corbet@lwn.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	the arch/x86 maintainers <x86@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Waiman Long <longman@redhat.com>, kvm <kvm@vger.kernel.org>,
	linux-doc@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Jan H . Schoenherr" <jschoenh@amazon.de>,
	Anthony Liguori <aliguori@amazon.com>
Subject: Re: [PATCHv3 1/1] locking/qspinlock/x86: Avoid test-and-set when PV_DEDICATED is set
Date: Fri, 10 Nov 2017 09:19:06 +0100	[thread overview]
Message-ID: <bbeaf134-b948-6ed4-d8a6-cdcb5279d1b3@redhat.com> (raw)
In-Reply-To: <CANRm+CxpcH5e1pspXSA6TgU-XCHntKHbg3R8iAyn5PnqFQsiWg@mail.gmail.com>

On 10/11/2017 07:07, Wanpeng Li wrote:
>>> You should also add a cpuid flag in kvm part.
>> It is better without that.  The flag has no dependency on KVM (kernel
>> hypervisor) code.
> Do you mean -cpu host, +xxxx,I think it will result in "warning: host
> doesn't support requested feature: CPUID.40000001H:eax.XXXXXX"

There are some exceptions where QEMU overrides the values of
KVM_GET_SUPPORTED_CPUID.

I think it is better to add the flag to KVM *and* to QEMU's override in
kvm_arch_get_supported_cpuid (target/i386/kvm.c).

Paolo

      reply	other threads:[~2017-11-10  8:19 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-06 20:26 Eduardo Valentin
2017-11-07 12:23 ` Paolo Bonzini
2017-11-07 12:39   ` Eduardo Valentin
2017-11-07 12:43     ` Paolo Bonzini
2017-11-08  8:45       ` Eduardo Valentin
2017-11-08 17:36 ` Radim Krčmář
2017-11-09  8:55   ` Eduardo Valentin
2017-11-09 14:17     ` Radim Krčmář
2017-11-16  4:54       ` Eduardo Valentin
2017-11-27  0:43         ` Wanpeng Li
2017-11-09 12:43 ` Wanpeng Li
2017-11-09 15:53   ` Pankaj Gupta
2017-11-09 16:05     ` Radim Krcmar
2017-11-09 16:17       ` Peter Zijlstra
2017-11-09 16:37         ` Pankaj Gupta
2017-11-09 16:45         ` Radim Krcmar
2017-11-09 17:12           ` Peter Zijlstra
2017-11-09 17:15             ` Peter Zijlstra
2017-11-09 17:28               ` Peter Zijlstra
2017-11-09 17:35                 ` Radim Krcmar
2017-11-10  2:07               ` Wanpeng Li
2017-11-10  7:59                 ` Peter Zijlstra
2017-11-10  8:04                   ` Wanpeng Li
2017-11-09 17:31             ` Radim Krcmar
2017-11-09 16:00   ` Radim Krcmar
2017-11-10  6:07     ` Wanpeng Li
2017-11-10  8:19       ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bbeaf134-b948-6ed4-d8a6-cdcb5279d1b3@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=corbet@lwn.net \
    --cc=eduval@amazon.com \
    --cc=hpa@zytor.com \
    --cc=jschoenh@amazon.de \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mingo@redhat.com \
    --cc=msw@amazon.com \
    --cc=peterz@infradead.org \
    --cc=rkrcmar@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®