From: Rik van Riel <riel@surriel.com>
To: Yuan-Hao Hsu <aa9736195201@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
John Hubbard <jhubbard@nvidia.com>, Peter Xu <peterx@redhat.com>,
Suren Baghdasaryan <surenb@google.com>,
linux-mm@kvack.org
Subject: Re: [RFC PATCH v3 7/8] mm/gup: walk multiple PTEs per follow_page_pte() call
Date: Wed, 14 Oct 2026 21:49:41 -0400 [thread overview]
Message-ID: <bbeb70884055b85f99f93795deb5d6af8f64cd64.camel@surriel.com> (raw)
In-Reply-To: <20261014215451.515-1-aa9736195201@gmail.com>
On Thu, 2026-10-15 at 05:54 +0800, Yuan-Hao Hsu wrote:
>
> You already mentioned on 3/8 moving the gup_fill_pages() call out of
> the lock so the PUD path can share the helper; this makes it more
> than a cleanup. Storing pages[] under the lock is cheap; could the
> flushes move after pte_unmap_unlock() and run over pages[0..nr), the
> way follow_pmd_mask() and follow_pud_mask() do it after 5/8 and the
> way __get_user_pages() did it before the series? With pages == NULL
> there is nothing to flush either way.
>
Good point. I'll move the cache flushing to a separate
function for v4.
Thank you for pointing out this issue.
--
All Rights Reversed.
next prev parent reply other threads:[~2026-10-15 1:49 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 2:51 [RFC PATCH v3 0/8] batch lookups in follow_page_mask() Rik van Riel
2026-08-11 2:51 ` [RFC PATCH v3 1/8] mm/gup: break out gup_fill_pages() helper Rik van Riel
2026-08-28 21:24 ` Suren Baghdasaryan
2026-08-11 2:51 ` [RFC PATCH v3 2/8] mm/gup: convert follow_page_mask() to return a long Rik van Riel
2026-08-28 21:28 ` Suren Baghdasaryan
2026-08-11 2:51 ` [RFC PATCH v3 3/8] mm/gup: split follow_page_pte_commit() out of follow_page_pte() Rik van Riel
2026-08-12 11:50 ` David Hildenbrand (Arm)
2026-08-12 13:02 ` Rik van Riel
2026-08-12 13:23 ` David Hildenbrand (Arm)
2026-08-12 16:19 ` Rik van Riel
2026-08-21 17:38 ` Rik van Riel
2026-08-21 22:04 ` John Hubbard
2026-08-22 13:20 ` Rik van Riel
2026-08-22 21:31 ` John Hubbard
2026-08-24 13:20 ` Rik van Riel
2026-08-11 2:51 ` [RFC PATCH v3 4/8] mm/gup: break out follow_one_pte() helper Rik van Riel
2026-08-28 23:47 ` Suren Baghdasaryan
2026-08-29 2:11 ` Rik van Riel
2026-08-11 2:51 ` [RFC PATCH v3 5/8] mm/gup: fill the pages array outside the pud/pmd lock Rik van Riel
2026-08-29 3:00 ` Suren Baghdasaryan
2026-08-11 2:51 ` [RFC PATCH v3 6/8] mm/gup: return a huge page's full count from follow_page_mask() Rik van Riel
2026-08-11 2:51 ` [RFC PATCH v3 7/8] mm/gup: walk multiple PTEs per follow_page_pte() call Rik van Riel
2026-08-29 3:06 ` Suren Baghdasaryan
2026-10-14 21:54 ` Yuan-Hao Hsu
2026-10-15 1:49 ` Rik van Riel [this message]
2026-08-11 2:51 ` [RFC PATCH v3 8/8] mm/gup: batch contiguous same-folio PTEs into one refcount grab Rik van Riel
2026-08-12 11:41 ` [RFC PATCH v3 0/8] batch lookups in follow_page_mask() David Hildenbrand (Arm)
2026-08-25 7:52 ` Christoph Hellwig
2026-08-25 13:37 ` Rik van Riel
2026-08-26 4:39 ` Christoph Hellwig
2026-08-26 7:35 ` Christoph Hellwig
2026-08-26 8:27 ` David Hildenbrand (Arm)
2026-08-26 13:36 ` Rik van Riel
2026-10-14 21:45 ` Yuan-Hao Hsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbeb70884055b85f99f93795deb5d6af8f64cd64.camel@surriel.com \
--to=riel@surriel.com \
--cc=aa9736195201@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®