From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 570E7368D48 for ; Tue, 2 Jun 2026 18:18:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780424338; cv=none; b=eOXa3R/BwKFa/OSG5hotnZgfHo+hysPIlqZKdYxFUtpjG9kdffspLIGJQN7Vny5VWVZ6mIiBC1HpCquiDNreWNIVzrsSGxXec/0hp2a1Slz96aOOgXlcSMN1mP3xJ5jaOcdrntWCqUy0mtwgeCZ6wbXy0vo9IA9cQddARJ9qsdw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780424338; c=relaxed/simple; bh=g02Q++0/ykbtuuhX11PMUnV0ksVfrlX1ZVKZWxb8kbM=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=ZSi9Lof53ofVgYxGHcj+rcqlinbff/OivzeXUd15gau60nCX4X9VmLXnN4Yii+oui5YuBQnjRKi3+QZptj7pV3lC20PbonKSX9byLYIMI56MDXcwGvrTgaECr+9uoDPmAHdlNKs0W67ksvWMebT3s2zL6Jcd+vGc5XAjYGBE1b0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NQ3AbZDA; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NQ3AbZDA" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-490b2b037d2so8601245e9.3 for ; Tue, 02 Jun 2026 11:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780424336; x=1781029136; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=jUyxNLpyIO/I2EuqyRj91ya//AXEJpBPxi98gtHkrko=; b=NQ3AbZDA515s4pVcel+b/aUUxKMFdW/tkUohreNjd0yCdUodkxhM56YEP+Qlq8PXuF aE3TFs5yj4wZWoBrnDu8TTkPX/KmTc02uR7hXLe3Z9Wm34glOQnakfTj9TFu3Vv7RDZ/ z5ODwLnsWhOlvpB4qE0+ljXhCBNG3wbpXYmoTNC24rCM/ik5lD0YPRnWfPQxeqi5A0eh QeZBe9JPnbtkAtdU2HyDFhVWoOuGtVm4MHbH/qjjSeimUXg7ByI60oTSEQp7PxtTzYod +M8ZR3Pp87ZNUlErV5tlcg6cdqvl3Z2mjitHWhjIPKdhfmt8Nbiq2Bce+OvDisE2MuVb bGbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780424336; x=1781029136; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jUyxNLpyIO/I2EuqyRj91ya//AXEJpBPxi98gtHkrko=; b=X7Wz+s6y8knYAkv79SDTaxDd2uHmxiRjdXE9RR9DLIZmhJKsERcxIAzQpzmx38HOzN Xw+Fk9z4wwo0ZbzbVrfA+pVw/2cGMpWlBdcRBYUwFifuQodgdYOka3NbwMj53xX+wxNV q/GfybDy2xix6DcPUdn47CHXW5oUSFGCT+onQ48bRQrWxm4KcfqP5FlRtMWn//PEuwCo SFn1IJ6fjf6tMojPFEFDKqs8/9hv2wLXTf3ZT/kznYIlsuKmvnTbhrh0fBwQL6Uw3DFe b+4bllCy3tP8rfynD9bmvV6PEBlBIRXdKwkzgS2M5MfUmyLK7kVAjGNeRlJntwKRPs7+ 7BBA== X-Forwarded-Encrypted: i=1; AFNElJ9wrCLxVCptXM0JsY/wCqpXHPYAZsHKXvapnYrgFACMzkYuDpBc638MCCTprFrjpjy3OXmHs9jzzs7U6Zw=@vger.kernel.org X-Gm-Message-State: AOJu0YzgKDgzBBEIHn5jiTLctfYsGTMLtCisZ5II3XoI1FfDtV7pTdLd w2GZPC/dzJlCldNPvN010KgC4pqBJvCedMGVXCK2Sw55hYSGQiTIq20= X-Gm-Gg: Acq92OE2MdZ8rAj1Lw56IvIbxtJYbGtQ1B20C3BPpZmygCPMoISZeBMw3sfCEk33tVt ti4vyJJHyZhQO2KAaXlvttdNONTs4d5sMn/1hm3yzk4XggFcNwXO02psBk6khhgULP+jLQJLr+K lW0CqVSizunDwiuPZqSH+8r++nL8f+iIgxvwAtwc2DSxNrXzRubzQVT803gxO5OAFIBOtyYAA7e OQD0q2b2uAJ6MxmuR0bdCq/kVpansrNaDVo2FDQp7SyNBZ0uJsaet5CLS3YdjcbjzIeHOwyxmJc tjE5AealwTQcwWpswTASQ/VMtQ/Inbo28+6Olm+4/umhSTZb1wKSZVNtQzDkeCLoX8uogn4Sm0C YGLyRt80ou5ynmvelxXGg2duBKDYZSxFkNDTjcNls01YAmVhCi2v6ieR89iOkGIuyt9+JMpEeNG vTCXlH4Ij0FG1DyKIJio+HPQ== X-Received: by 2002:a05:600c:3b19:b0:490:a9d6:8f2f with SMTP id 5b1f17b1804b1-490b50391f0mr14127995e9.4.1780424335608; Tue, 02 Jun 2026 11:18:55 -0700 (PDT) Received: from p183 ([178.172.146.10]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490b588cbcfsm1273505e9.12.2026.06.02.11.18.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 11:18:54 -0700 (PDT) Date: Tue, 2 Jun 2026 21:21:38 +0300 From: Alexey Dobriyan To: Andy Shevchenko Cc: Petr Mladek , Thorsten Blum , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] lib/vsprintf: replace min_t/max_t with min/max Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Andy Shevchenko wrote: > > > if (spec.field_width > 0) > > > - len = min_t(int, spec.field_width, 64); > > > + len = min(spec.field_width, 64); > > > > Honestly, I do not see any big advantage in replacing the macros. > > In fact, the min()/max() macros are even more complex because > > they check compatibility of the compared types. > > > > IMHO, this adds non-necessary churn into the git history without > > an obvious advantage. > > The advantage I see is to give a good example to others to avoid min_t() > whenever is possible. I am not insisting to include this patch, just > share my 2 cents. Patch is good. "field_width" was bitfield for a long time, so min/max couldn't be used. %alexey