From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F67DC77B7A for ; Fri, 2 Jun 2023 17:22:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235873AbjFBRWM (ORCPT ); Fri, 2 Jun 2023 13:22:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235248AbjFBRWJ (ORCPT ); Fri, 2 Jun 2023 13:22:09 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED5DB1A2 for ; Fri, 2 Jun 2023 10:22:07 -0700 (PDT) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 352Fjp6X020574; Fri, 2 Jun 2023 17:21:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=CV/zv2rEx6HI1bxvAwZy7pg+66Syy5hdPrY4LUHd8WY=; b=LoKJ0jB8rEZZywhEr9O+n/hjBsinX6Z3vr8N/tkk6AXYqZS/xKFlTvj9JntjUSMYROo6 7m4Xrr/SHZrUnnSTfppwESX/+wu/QcXTktuzIrQyfMKuAM4YYlA1vQIQHeO1etRLJtCj SKUBqgOBZ0YCPhcAx0oKf/Jkz6lgGKMJm1l/xbIKxOV+QmdKED9hmy3kRTPI97Usel9R S4WuZBkg62KQz7BS6Nss7AxnH/zrcXQbgLNUgH2WuZArygO2SY4kYAe5SbFW0LUmtMjE sUscWNLSXyGr08a1lc/Yj/XaLOJpMNIrQlz0cM5cg5z2BuDpsZCWXU3z386Mk+Yb63+u fA== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qycwe95rm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 02 Jun 2023 17:21:55 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 352HLsEF001287 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 2 Jun 2023 17:21:54 GMT Received: from [10.226.59.182] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Fri, 2 Jun 2023 10:21:53 -0700 Message-ID: Date: Fri, 2 Jun 2023 11:21:53 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH] accel/ivpu: ivpu_ipc needs GENERIC_ALLOCATOR Content-Language: en-US To: Randy Dunlap , CC: kernel test robot , Oded Gabbay , , Jacek Lawrynowicz , Stanislaw Gruszka , Andrzej Kacprowski , Krystian Pradzynski , Daniel Vetter References: <20230526044519.13441-1-rdunlap@infradead.org> From: Jeffrey Hugo In-Reply-To: <20230526044519.13441-1-rdunlap@infradead.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: gkOGvE_uJrjby2pbGcuIuov8leJcUUYg X-Proofpoint-GUID: gkOGvE_uJrjby2pbGcuIuov8leJcUUYg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-02_13,2023-06-02_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=857 lowpriorityscore=0 malwarescore=0 adultscore=0 mlxscore=0 bulkscore=0 clxscore=1011 spamscore=0 suspectscore=0 phishscore=0 impostorscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2306020132 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/25/2023 10:45 PM, Randy Dunlap wrote: > Drivers that use the gen_pool*() family of functions should > select GENERIC_ALLOCATOR to prevent build errors like these: > > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free': > include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner' > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_alloc_algo': > include/linux/genalloc.h:138: undefined reference to `gen_pool_alloc_algo_owner' > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free': > include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner' > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `ivpu_ipc_init': > drivers/accel/ivpu/ivpu_ipc.c:441: undefined reference to `devm_gen_pool_create' > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_add_virt': > include/linux/genalloc.h:104: undefined reference to `gen_pool_add_owner' > > Fixes: 5d7422cfb498 ("accel/ivpu: Add IPC driver and JSM messages") > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Link: https://lore.kernel.org/all/202305221206.1TaugDKP-lkp@intel.com/ > Cc: Oded Gabbay > Cc: dri-devel@lists.freedesktop.org > Cc: Jacek Lawrynowicz > Cc: Stanislaw Gruszka > Cc: Andrzej Kacprowski > Cc: Krystian Pradzynski > Cc: Jeffrey Hugo > Cc: Daniel Vetter Reviewed-by: Jeffrey Hugo