From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BC92EB64DD for ; Thu, 27 Jul 2023 05:46:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232183AbjG0FqY (ORCPT ); Thu, 27 Jul 2023 01:46:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232077AbjG0FqH (ORCPT ); Thu, 27 Jul 2023 01:46:07 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC6F12D42 for ; Wed, 26 Jul 2023 22:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690436718; x=1721972718; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=HwAWVBPhPifYPtR9YPCU/MvGfTwewwbPzIRftArYbaE=; b=J7cndJ4vdedkaO/skkHXNBkbCWxZM8wxvsChy1EJP8/nnIQIRaKEFee9 +KWTEjSNycCmqDoiq03To9JRDvtm9qrEFE2fsTXsBvmy2DVP5PRRbol77 K0vZyE6uwJj/U44ymu3mIxRUr0XbrC7IIdPK4GP/PhR62qTIdPIDUcfMN yPkChF4sFMLD5sUzl/aiQoKDmgza2s6QDcjZNqeKmIDQG8JzsaMTQuO1c RHuYtrh081FRUHBE5ZOFTrupUN66SE+sGes3doPbkK4uNJoAYEGBVyqju eIhWVaN7W95h4DauP/ZZgsKZFjhfqov+RKtzq71haN3wd1Td0GqkXLWvI g==; X-IronPort-AV: E=McAfee;i="6600,9927,10783"; a="371821131" X-IronPort-AV: E=Sophos;i="6.01,234,1684825200"; d="scan'208";a="371821131" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2023 22:41:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10783"; a="756522634" X-IronPort-AV: E=Sophos;i="6.01,234,1684825200"; d="scan'208";a="756522634" Received: from mseillie-mobl.ger.corp.intel.com (HELO [10.249.37.247]) ([10.249.37.247]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2023 22:41:55 -0700 Message-ID: Date: Thu, 27 Jul 2023 07:41:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2] ASoC: Intel: maxim-common: get codec number from ACPI To: "Liao, Bard" , "Lu, Brent" , "alsa-devel@alsa-project.org" Cc: "Rojewski, Cezary" , Liam Girdwood , Peter Ujfalusi , Ranjani Sridharan , Kai Vehmanen , Mark Brown , Jaroslav Kysela , Takashi Iwai , "linux-kernel@vger.kernel.org" , "Zhi, Yong" , Ajye Huang , "Bhat, Uday M" , Terry Cheong , "Chiang, Mac" , "R, Dharageswari" , Kuninori Morimoto References: <20230720092628.758834-1-brent.lu@intel.com> <20230720092628.758834-2-brent.lu@intel.com> Content-Language: en-US From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/27/23 5:21 AM, Liao, Bard wrote: > > On 7/27/2023 10:14 AM, Lu, Brent wrote: >>> >>> max_98390_components[] and max_98390_4spk_components[] are still used >>> >>> by sof_rt5682.c, we should remove them in the same patch. >>> >>> Maybe combine the 2 patches together? >>> >>> >> I've got your point but these two patches are doing two things: one is >> refactor the >> code and add a detection feature, the other one is removing the quirk. >> Not sure if >> it's proper to merge them. > > The point is that if you remove them and they are still used somewhere, > > you will break the build. i.e. Kernel will not compile if we apply the > > first patch only. IOW git bisect is broken and that's a big no-no.