From: Andrzej Hajda <a.hajda@samsung.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
"Sun, Jing A" <jing.a.sun@intel.com>,
Takashi Iwai <tiwai@suse.de>
Cc: "airlied@linux.ie" <airlied@linux.ie>,
"Vetter, Daniel" <daniel.vetter@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Thierry Reding <treding@nvidia.com>,
Emil Velikov <emil.l.velikov@gmail.com>
Subject: Re: [PATCH]"drm: change DRM_MIPI_DSI module type from "bool" to "tristate".
Date: Tue, 11 Oct 2016 11:53:09 +0200 [thread overview]
Message-ID: <bc014930-9957-8ca4-435d-737b0fdb3920@samsung.com> (raw)
In-Reply-To: <87lgxvqlg3.fsf@intel.com>
On 11.10.2016 11:33, Jani Nikula wrote:
> On Tue, 11 Oct 2016, "Sun, Jing A" <jing.a.sun@intel.com> wrote:
>> It's needed that DRM Driver module could be removed and reloaded after
>> kernel booting on the projects that I have been working on, and I hope
>> such module type change could be accepted. Looks like Iwai has similar
>> change request as well. Would you please review it and let us know if
>> any concerns?
> Looking at the Kconfig, selecting CONFIG_DRM_MIPI_DSI is against the
> recommendations of Documentation/kbuild/kconfig-language.txt:
>
> select should be used with care. select will force
> a symbol to a value without visiting the dependencies.
> By abusing select you are able to select a symbol FOO even
> if FOO depends on BAR that is not set.
> In general use select only for non-visible symbols
> (no prompts anywhere) and for symbols with no dependencies.
> That will limit the usefulness but on the other hand avoid
> the illegal configurations all over.
All existing drivers which selects DRM_MIPI_DSI also depends on DRM.
So the dependency is always true. I am not sure if it could not change in
the future, but in such case mipi_dsi bus should be completely detached from
DRM framework, I hope we have not such case yet :)
>
> Indeed, you may end up with CONFIG_DRM_MIPI_DSI=y and CONFIG_DRM=m,
> which violates DRM_MIPI_DSI dependency on CONFIG_DRM. This is broken and
> should be fixed. The suggested patch does *not* fix this issue.
At the moment it should not be possible.
Regards
Andrzej
next prev parent reply other threads:[~2016-10-11 9:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 7:31 Sun, Jing A
2016-10-10 8:28 ` Jani Nikula
2016-10-10 9:57 ` Takashi Iwai
2016-10-11 8:40 ` Sun, Jing A
2016-10-11 9:17 ` Andrzej Hajda
2016-10-11 9:33 ` Jani Nikula
2016-10-11 9:53 ` Andrzej Hajda [this message]
2016-10-12 3:08 ` Sun, Jing A
2016-10-12 6:51 ` Daniel Vetter
2016-10-12 9:04 ` Sun, Jing A
2016-10-12 10:52 ` Jani Nikula
2016-10-12 11:28 ` Emil Velikov
2016-10-12 14:28 ` Jani Nikula
2016-10-20 13:20 ` Andrzej Hajda
2016-10-20 13:44 ` Jani Nikula
2016-10-21 12:19 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc014930-9957-8ca4-435d-737b0fdb3920@samsung.com \
--to=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=jani.nikula@linux.intel.com \
--cc=jing.a.sun@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®