From: "libaokun (A)" <libaokun1@huawei.com>
To: <zbr@ioremap.net>, <linux-kernel@vger.kernel.org>
Cc: <weiyongjun1@huawei.com>, <yuehaibing@huawei.com>,
<yangjihong1@huawei.com>, <yukuai3@huawei.com>
Subject: Re: [PATCH -next] w1: ds1wm: Remove set but not used variable 'inten'
Date: Tue, 15 Jun 2021 09:59:21 +0800 [thread overview]
Message-ID: <bc019cfa-95e7-c88b-89a9-430a6c21b220@huawei.com> (raw)
In-Reply-To: <20210529035945.2754099-1-libaokun1@huawei.com>
ping
在 2021/5/29 11:59, Baokun Li 写道:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/w1/masters/ds1wm.c: In function 'ds1wm_probe':
> drivers/w1/masters/ds1wm.c:512:5: warning:
> variable ‘inten’ set but not used [-Wunused-but-set-variable]
>
> It never used since introduction.
>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
> drivers/w1/masters/ds1wm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/w1/masters/ds1wm.c b/drivers/w1/masters/ds1wm.c
> index f661695fb589..f59d92865ecb 100644
> --- a/drivers/w1/masters/ds1wm.c
> +++ b/drivers/w1/masters/ds1wm.c
> @@ -509,7 +509,6 @@ static int ds1wm_probe(struct platform_device *pdev)
> struct ds1wm_driver_data *plat;
> struct resource *res;
> int ret;
> - u8 inten;
>
> if (!pdev)
> return -ENODEV;
> @@ -564,7 +563,7 @@ static int ds1wm_probe(struct platform_device *pdev)
> ds1wm_data->reset_recover_delay = plat->reset_recover_delay;
>
> /* Mask interrupts, set IAS before claiming interrupt */
> - inten = ds1wm_read_register(ds1wm_data, DS1WM_INT_EN);
> + ds1wm_read_register(ds1wm_data, DS1WM_INT_EN);
> ds1wm_write_register(ds1wm_data,
> DS1WM_INT_EN, ds1wm_data->int_en_reg_none);
>
prev parent reply other threads:[~2021-06-15 2:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-29 3:59 Baokun Li
2021-06-15 1:59 ` libaokun (A) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc019cfa-95e7-c88b-89a9-430a6c21b220@huawei.com \
--to=libaokun1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=yangjihong1@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=yukuai3@huawei.com \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®