From: Randy Dunlap <rdunlap@infradead.org>
To: Sumitra Sharma <sumitraartsy@gmail.com>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, outreachy@lists.linux.dev
Subject: Re: [PATCH v2] Staging: octeon: Fix line ending with '('
Date: Thu, 16 Mar 2023 09:10:23 -0700 [thread overview]
Message-ID: <bc047600-4e40-5d7b-980c-bdab28324057@infradead.org> (raw)
In-Reply-To: <20230316155202.GA82100@sumitra.com>
Hi--
On 3/16/23 08:52, Sumitra Sharma wrote:
> Adhere to coding-style.
>
> Checkpatch has reported code style warning:
> CHECK: Lines should not end with a '('.
>
Not to complain about the patch, but where is this documented
in coding-style? I searched for it and cannot find it.
Thanks.
> Enhance the design of a function header:
> Align the function parameters immediately after '(' in a single line.
>
> Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
> ---
>
> v2: Change patch subject and description.
>
> drivers/staging/octeon/octeon-stubs.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
> index 7a02e59e283f..3e7b92cd2e35 100644
> --- a/drivers/staging/octeon/octeon-stubs.h
> +++ b/drivers/staging/octeon/octeon-stubs.h
> @@ -1372,9 +1372,7 @@ static inline void cvmx_fau_async_fetch_and_add32(uint64_t scraddr,
> int32_t value)
> { }
>
> -static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(
> - int interface,
> - int port)
> +static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(int interface, int port)
> {
> union cvmx_gmxx_rxx_rx_inbnd r;
>
--
~Randy
next prev parent reply other threads:[~2023-03-16 16:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 15:52 Sumitra Sharma
2023-03-16 16:10 ` Randy Dunlap [this message]
2023-03-16 16:15 ` Deepak R Varma
[not found] ` <20230316162442.GA82267@sumitra.com>
2023-03-16 16:37 ` Deepak R Varma
2023-03-16 16:56 ` Sumitra Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc047600-4e40-5d7b-980c-bdab28324057@infradead.org \
--to=rdunlap@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=sumitraartsy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®