From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26A5C3385BC for ; Fri, 9 Jan 2026 10:49:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767955775; cv=none; b=prOTAdktii6Hy3c6QZO/y4w7wvWGFSdthwcFbSQVe0XAuMaBBIUng0BHnnqmxcfAz2zHP68nZQUy/fJqg/LjfvpkXPrmzPAOMPLbRLhdmMHEreDKj1Q86wmLj4ldHMVDjpBNPv9nO7oFMayKqlEGib+LQJQY78xny/tnBS+dKo4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767955775; c=relaxed/simple; bh=b3H6qKbIKCO0gP1++LTaVcskDS3sOVqVKZEw8Z9jCh8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZR0X+XJ7NewLPx5rtp3QJDtUF1UpqRJ9lMu+sS4JZ89CW+XDuf1KcZWaPo7UmbZO61q6H5a4/DT3O4gRL8CZYRi6mXHYIOe5OGrfY8/Un4EoO444BiXeGbx9n/9hH1OUPVIEN/g4Ff/ek+IxbpEN4JGwkEs8GX2mPNVfBbRJvCg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bjnBgW18; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZaXUURkM; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bjnBgW18"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZaXUURkM" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6099N6IS472718 for ; Fri, 9 Jan 2026 10:49:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gF51mEvG4UeNNiUkScsa3C3kNkmiu6kc2Haqu7j3LQo=; b=bjnBgW18HM23IIIg 7yplMCrIxwbp1qRc/Bd1WZ2lxgTTlWOAmjwnYMIDZDKeB1+ptlfmtrGrsICQKk8I F0Wf/uwFgqHhKpY9t+ZqgKLbVzNptZLd/mbLO6iJ1NhX52QrTLl3SeeReuwr/Dt1 ugFsnRAaBrK17g01HIz44SFVFqNnLYKScw28ImjwuE/5PVKqSHW4Uk9uKKmBPB8h JrTt/VfR8kK7j5I2rdjvPexJ5jIRfaKdeM+IB6P65z20qJLfmryOGDyqdTJMuGog TzQ68twuu1a7c/vRtPFho8P+ySC+DLgi/cnlNBk4MptIXUJlWv4cz+Ih5ZWZs954 GabsaA== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bjy0a08j6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 09 Jan 2026 10:49:33 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4f3564e2321so8808501cf.3 for ; Fri, 09 Jan 2026 02:49:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767955772; x=1768560572; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gF51mEvG4UeNNiUkScsa3C3kNkmiu6kc2Haqu7j3LQo=; b=ZaXUURkMDp/YaURIvAKgK6qZNeREEBz3wgnBHZQBQt1AY1HTfmjrsMwdgQhGkyoE6z hYx9wLbfNSTzv97l9ZjPT4QLsm+TmFNv17RvGvjpM/YzpK8Y+b65kpCHz/0QR1GSIvTj Z2DgHljKvTvCCAN4lKUZQRhoroYEka164vehxDWklatgofPbQaDGPuunVbmu7S0tmhb4 x4HLdnE0A2bD8U9xQqbg36vU2B1lwuu2gLDCxWTevkQ+bMgHbZQuOyfk8lezhGgA83kV NcdJXwvfPfgs+6fdFOXUaU1XkTv+WcMvv7Gq1bLGJ9tli832KScGF4iW+dp7MkOhjxkh Po9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767955772; x=1768560572; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gF51mEvG4UeNNiUkScsa3C3kNkmiu6kc2Haqu7j3LQo=; b=B2W1YBktxHJ/GP9DGCkxQ/RGNRtvVhi+lyBqbYa/716/0dcXzLNsTPwy/SA52NGzre wAXlc64gOsfLpURo15Ki5ap69Qh1FPXmqA+SNozOePjnP3gHAw+/HHTe8BJo7pn4tZt6 rmmuMNmOa2e3eiSvVHrJfaUK8h81p25MWG+HYIoG1qse3xfygVLCICe4d57WjCogk0iG sRkMHS5h6tcgwWUe2TLu7+wHDpnYXhZQ8JvpuphxKN13l+wk3b+vI9yyUdaI1wip7WdZ iTl3MBs1yfxE/XJS7n0xWdQK9L7HG2wJYU498mIFOJzeD/75nn8cYIw57En7UqORA51c tUxA== X-Forwarded-Encrypted: i=1; AJvYcCUIzp4ln4d9Y1JNGxhXzA9C6ll9gwAo1jzvsAHAeP4LpEXxS6BAq2mi9RWlScmgZzbqlKDSAxIlTJFJh7w=@vger.kernel.org X-Gm-Message-State: AOJu0YwlhUnb8aRveW8X6FlcHrhAu32yIRoaCNG8JrT1ubrLrYdlzLhH /64v+fo1JRQBx6VP9+4QEgvygMi0aUXkp8jQo8L3Fn8JB6kohxqYm0hMg5TwuBvgde0c6Xl1XRo Y+4+9D/NZxltKyTnT2kuOFJQuXhVSGhOXyCnQRUokuOVHUhDcfjNfK1+qrePuv09voqtNBXkuAK 0= X-Gm-Gg: AY/fxX6YRgCAvE2kcqaBxnVBJxWmhobVzJVtnesvK+xZ6/+wJOyE0swmq7fe1oGd7qX qHQmbuWScpyaPtvHRq+I5qyaO5xA1oT3/ppOlrypuRRoi0T+RZV8LKnnaB+7FOHxKYRmvRYR4oN WleAl+rw4DiUOoU077XIuzrLQ96nUNKRGxOmgbnFQSNAg4zmevdFhrTfZgVmRYoAl0YQj3ehRqO aEgcDh8ZibBmZbdFqzUUXD3W6F8nrn0iqVoQ0i4rqjUGQJahHyqwVH5D+4p4Y5t2cWc6f48w+95 DP3ZDcVEMTXcEnmMaUngpO8ruIY7bYkywSX4wkUlskcNUjJlPx5UoTtyVfaayDXbWxynJaTI646 gmWnhUIeaKAyBqHnBkM9dId9fh9e/xdYVXESD2Ksmcap/9o9uuCaoCsOVudcuAaAp3uc= X-Received: by 2002:ac8:5d4d:0:b0:4ef:be12:7b28 with SMTP id d75a77b69052e-4ffb4a54ff2mr101486121cf.9.1767955772368; Fri, 09 Jan 2026 02:49:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IE34C1rSk2bsxT2qW4/hAMnMPSjiOmm8OXFZ84ylaKTmq5w3ox6qX+TvXPP+TFiQ98bJ1mxWw== X-Received: by 2002:ac8:5d4d:0:b0:4ef:be12:7b28 with SMTP id d75a77b69052e-4ffb4a54ff2mr101485991cf.9.1767955771995; Fri, 09 Jan 2026 02:49:31 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507b8c4454sm10039009a12.3.2026.01.09.02.49.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jan 2026 02:49:31 -0800 (PST) Message-ID: Date: Fri, 9 Jan 2026 11:49:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] phy: qcom: edp: Fix NULL pointer dereference for phy v6 (x1e80100) To: Val Packett , Vinod Koul , Neil Armstrong , Abel Vesa , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260109045214.5983-1-val@packett.cool> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260109045214.5983-1-val@packett.cool> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA5MDA3OCBTYWx0ZWRfX0J34lMMC8DFr zSxKtuZ6YmJfaOTx438s8+HqX7VkM4WErQ7bB7pTlDvY7wdjuS9zmbepl08nbZznUL4gD3ry3v5 7jUy2hZ4rGCufFq3lO/5jB8E4ObpbRdszdvqigalIFoOc0e+41fd125CZqVkhgKXaX5/s+a+jpI vL7NkDLl5WnLyX3drSxqqxBPaUqd8wM2UsXpiWB8r6xnKdIxAveVmzBbNU3U48PcNER0nmIh7AS QIxTHEzXzzGI1v6/aPTzvDT3OGn3F+eWXz9hsIIJlZmBa/M6JUCHo/G92nmZIr1CspxT6UGhFub LeSBfYWWM39tBUJWnUtsPaVIIyEHjjSdHMY0LJ6ySmJdLgeY7yHYA4hj1iXlccqJBzvmB4vS2eT Fw03trKqikVps7kkiXyPmJxrJjzUO+GvlKPRTZQtkokMEfexg1nrCYZGjIRtnCQD1BRPYIb+tm9 +w8Jr/IIOL3oTciooJw== X-Proofpoint-ORIG-GUID: BfSgYmo9zV6zImnPLd7_UvRnasuHmCIr X-Proofpoint-GUID: BfSgYmo9zV6zImnPLd7_UvRnasuHmCIr X-Authority-Analysis: v=2.4 cv=QPFlhwLL c=1 sm=1 tr=0 ts=6960dd3d cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Bah9ZvdxITrzPEqZxngA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-09_03,2026-01-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601090078 On 1/9/26 5:50 AM, Val Packett wrote: > For Glymur SoC support, the com_clk_fwd_cfg callback was added, and a > stub implementation was added for the v4 of the hardware. However it > was omitted for the v6, causing a NULL pointer dereference oops on > Hamoa/Purwa (X1E/X1P) SoC devices. Fix by adding the appropriate stub. > > Fixes: add66a6673bc ("phy: qcom: edp: Add Glymur platform support") > Signed-off-by: Val Packett > --- > drivers/phy/qualcomm/phy-qcom-edp.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c > index 13feab99feec..a17492db21d8 100644 > --- a/drivers/phy/qualcomm/phy-qcom-edp.c > +++ b/drivers/phy/qualcomm/phy-qcom-edp.c > @@ -613,6 +613,11 @@ static int qcom_edp_phy_com_resetsm_cntrl_v6(const struct qcom_edp *edp) > val, val & BIT(0), 500, 10000); > } > > +static int qcom_edp_com_clk_fwd_cfg_v6(const struct qcom_edp *edp) > +{ > + return 0; > +} > + > static int qcom_edp_com_bias_en_clkbuflr_v6(const struct qcom_edp *edp) > { > /* Turn on BIAS current for PHY/PLL */ > @@ -758,6 +763,7 @@ static const struct phy_ver_ops qcom_edp_phy_ops_v6 = { > .com_power_on = qcom_edp_phy_power_on_v6, > .com_resetsm_cntrl = qcom_edp_phy_com_resetsm_cntrl_v6, > .com_bias_en_clkbuflr = qcom_edp_com_bias_en_clkbuflr_v6, > + .com_clk_fwd_cfg = qcom_edp_com_clk_fwd_cfg_v6, Let's just point it to the existing qcom_edp_com_clk_fwd_cfg_v4 Konrad