mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Val Packett <val@packett.cool>
To: Deepa Guthyappa Madivalara <deepa.madivalara@oss.qualcomm.com>,
	Bryan O'Donoghue <bod@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
	Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
	Abhinav Kumar <abhinav.kumar@linux.dev>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Nicolas Dufresne <nicolas.dufresne@collabora.com>,
	Hans Verkuil <hverkuil+cisco@kernel.org>
Subject: Re: [PATCH v10 0/5] Enable support for AV1 stateful decoder
Date: Thu, 8 Jan 2026 16:25:30 -0300	[thread overview]
Message-ID: <bc0aa47d-81a9-480b-b156-b0cb23179515@packett.cool> (raw)
In-Reply-To: <a8af1513-fda6-4809-80ae-bb07d2ed0db3@oss.qualcomm.com>


On 1/2/26 3:59 PM, Deepa Guthyappa Madivalara wrote:
>
> On 1/2/2026 3:01 AM, Val Packett wrote:
>>
>> On 1/2/26 7:44 AM, Bryan O'Donoghue wrote:
>>> On 02/01/2026 10:43, Val Packett wrote:
>>>>
>>>> On 12/10/25 3:59 PM, Deepa Guthyappa Madivalara wrote:
>>>>> Hi all,
>>>>>
>>>>> This patch series adds initial support for the AV1 stateful decoder
>>>>> codecs in iris decoder. Also it adds support for AV1 stateful decoder
>>>>> in V4l2. The objective of this work is to extend the Iris decoder's
>>>>> capabilities to handle AV1 format codec streams, including necessary
>>>>> format handling and buffer management.
>>>>
>>>> This is awesome, thanks!
>>>>
>>>> I've tested it with rpi-ffmpeg as well, and it works great (only
>>>> required one interesting logic change..
>>>> https://github.com/jc-kynesim/rpi-ffmpeg/pull/108) \o/


BTW, the rpi-ffmpeg maintainer is asking,

> for that flag_last code to trigger we have to have received an empty 
> capture buffer, which is the legacy method of signalling EOS, so 
> flag_last is a legitimate response. Is there something about AV1 
> stateful that means it is legitimate to receive empty capture buffers 
> mid stream? (grain & no-grain buffers spring to mind with an empty 
> frame if grain isn't enabled but that is pure speculation on my part 
> not supported by the documentation I've read). Now I'll grant that if 
> we get an EOS signalled this way we probably shouldn't attempt to 
> dequeue an event, but the "correct" answer of simply signalling EOS 
> back down the chain isn't what you want either?

(`flag_last` being an internal variable for an end-of-stream condition, 
so basically, I needed to make ffmpeg *not* interpret an empty capture 
buffer as an end-of-stream. I never saw those with H264/H265/VP9, but 
with AV1 one arrives after the first frame)


~val


  reply	other threads:[~2026-01-08 19:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-10 18:59 Deepa Guthyappa Madivalara
2025-12-10 18:59 ` [PATCH v10 1/5] media: uapi: videodev2: Add " Deepa Guthyappa Madivalara
2025-12-10 18:59 ` [PATCH v10 2/5] media: v4l2: Add description for V4L2_PIX_FMT_AV1 in v4l_fill_fmtdesc() Deepa Guthyappa Madivalara
2025-12-10 18:59 ` [PATCH v10 3/5] media: iris: Add support for AV1 format in iris decoder Deepa Guthyappa Madivalara
2025-12-10 18:59 ` [PATCH v10 4/5] media: iris: Define AV1-specific platform capabilities and properties Deepa Guthyappa Madivalara
2025-12-10 18:59 ` [PATCH v10 5/5] media: iris: Add internal buffer calculation for AV1 decoder Deepa Guthyappa Madivalara
2026-01-02 10:43 ` [PATCH v10 0/5] Enable support for AV1 stateful decoder Val Packett
2026-01-02 10:44   ` Bryan O'Donoghue
2026-01-02 11:01     ` Val Packett
2026-01-02 18:59       ` Deepa Guthyappa Madivalara
2026-01-08 19:25         ` Val Packett [this message]
2026-01-09 15:21           ` Nicolas Dufresne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc0aa47d-81a9-480b-b156-b0cb23179515@packett.cool \
    --to=val@packett.cool \
    --cc=abhinav.kumar@linux.dev \
    --cc=bod@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=deepa.madivalara@oss.qualcomm.com \
    --cc=dikshita.agarwal@oss.qualcomm.com \
    --cc=hverkuil+cisco@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=nicolas.dufresne@collabora.com \
    --cc=vikash.garodia@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®