From: Dongli Zhang <dongli.zhang@oracle.com>
To: David Ahern <dsahern@gmail.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net,
kuba@kernel.org, rostedt@goodmis.org, mingo@redhat.com,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
imagedong@tencent.com, joao.m.martins@oracle.com,
joe.jin@oracle.com, edumazet@google.com
Subject: Re: [PATCH v2 3/3] net: tun: track dropped skb via kfree_skb_reason()
Date: Sat, 19 Feb 2022 21:40:43 -0800 [thread overview]
Message-ID: <bc0e5a09-e139-0753-26f8-5bc5634a020d@oracle.com> (raw)
In-Reply-To: <29ff2768-ca3f-6a09-1df8-d703f85ecfac@gmail.com>
Hi David,
On 2/19/22 2:54 PM, David Ahern wrote:
> On 2/19/22 12:12 PM, Dongli Zhang wrote:
>> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
>> index aa27268edc5f..ab47a66deb7f 100644
>> --- a/drivers/net/tun.c
>> +++ b/drivers/net/tun.c
>> @@ -1062,13 +1062,16 @@ static netdev_tx_t tun_net_xmit(struct sk_buff *skb, struct net_device *dev)
>> struct netdev_queue *queue;
>> struct tun_file *tfile;
>> int len = skb->len;
>> + int drop_reason;
>
> enum skb_drop_reason
>
As mentioned in previous email ...
According to cscope, so far all 'drop_reason' are declared in type 'int' (e.g.,
ip_rcv_finish_core()).
I will change above to enum.
Thank you very much!
Dongli Zhang
prev parent reply other threads:[~2022-02-20 5:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-19 19:12 [PATCH v2 0/3] tun/tap: use kfree_skb_reason() to trace dropped skb Dongli Zhang
2022-02-19 19:12 ` [PATCH v2 1/3] net: tap: track dropped skb via kfree_skb_reason() Dongli Zhang
2022-02-19 22:46 ` David Ahern
2022-02-20 5:39 ` Dongli Zhang
2022-02-19 19:12 ` [PATCH v2 2/3] net: tun: split run_ebpf_filter() and pskb_trim() into different "if statement" Dongli Zhang
2022-02-19 19:12 ` [PATCH v2 3/3] net: tun: track dropped skb via kfree_skb_reason() Dongli Zhang
2022-02-19 22:54 ` David Ahern
2022-02-20 5:40 ` Dongli Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc0e5a09-e139-0753-26f8-5bc5634a020d@oracle.com \
--to=dongli.zhang@oracle.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=imagedong@tencent.com \
--cc=joao.m.martins@oracle.com \
--cc=joe.jin@oracle.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®