From: YueHaibing <yuehaibing@huawei.com>
To: Mark Brown <broonie@kernel.org>
Cc: <lgirdwood@gmail.com>, <perex@perex.cz>, <tiwai@suse.com>,
<kuninori.morimoto.gx@renesas.com>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] ASoC: soc-core: use DEVICE_ATTR_RO macro
Date: Sun, 16 May 2021 10:39:04 +0800 [thread overview]
Message-ID: <bc0f78b7-6ced-dfbc-d3c4-e6675dc4957e@huawei.com> (raw)
In-Reply-To: <20210514122442.GA6516@sirena.org.uk>
On 2021/5/14 20:24, Mark Brown wrote:
> On Fri, May 14, 2021 at 04:11:00PM +0800, YueHaibing wrote:
>
>> -static ssize_t pmdown_time_set(struct device *dev,
>> - struct device_attribute *attr,
>> - const char *buf, size_t count)
>> +static ssize_t pmdown_time_store(struct device *dev,
>> + struct device_attribute *attr,
>> + const char *buf, size_t count)
>
> This unrelated formatting change should be in a separate patch.
This change pmdown_time_set() to pmdown_time_store(), which trigger
checkpatch warning.
>
next prev parent reply other threads:[~2021-05-16 2:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 8:11 YueHaibing
2021-05-14 12:24 ` Mark Brown
2021-05-16 2:39 ` YueHaibing [this message]
2021-05-18 16:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc0f78b7-6ced-dfbc-d3c4-e6675dc4957e@huawei.com \
--to=yuehaibing@huawei.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®