From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755007AbdDQSxH (ORCPT ); Mon, 17 Apr 2017 14:53:07 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:33508 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753418AbdDQSxF (ORCPT ); Mon, 17 Apr 2017 14:53:05 -0400 Subject: Re: [PATCH] scsi: fc: remove redundant check of an unsigned long being less than zero To: Colin King , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org References: <20170414135802.6991-1-colin.king@canonical.com> Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Tyrel Datwyler Message-ID: Date: Mon, 17 Apr 2017 11:53:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170414135802.6991-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/14/2017 06:58 AM, Colin King wrote: > From: Colin Ian King > > The check for an unsigned long being less than zero is always false > so it is a redundant check and can be removed. > > Detected by static analysis with by PVS-Studio > > Signed-off-by: Colin Ian King Reviewed-by: Tyrel Datwyler > --- > drivers/scsi/scsi_transport_fc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c > index 2d753c93e07a..87b8f9d64d9b 100644 > --- a/drivers/scsi/scsi_transport_fc.c > +++ b/drivers/scsi/scsi_transport_fc.c > @@ -850,7 +850,7 @@ static int fc_str_to_dev_loss(const char *buf, unsigned long *val) > char *cp; > > *val = simple_strtoul(buf, &cp, 0); > - if ((*cp && (*cp != '\n')) || (*val < 0)) > + if (*cp && (*cp != '\n')) > return -EINVAL; > /* > * Check for overflow; dev_loss_tmo is u32 >