From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 563D3C433F5 for ; Mon, 14 Feb 2022 16:42:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244354AbiBNQm2 (ORCPT ); Mon, 14 Feb 2022 11:42:28 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:45556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356726AbiBNQmP (ORCPT ); Mon, 14 Feb 2022 11:42:15 -0500 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DCE2D88; Mon, 14 Feb 2022 08:41:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1644856895; x=1676392895; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=+CymjWSyTM2WBMyL/3aJhWzerfakuKzZr1vwvSFvdxU=; b=MmpMAVastdv9b31xy93WokFuompa0wW6SoZA+33WhZA+nCa+M6ZkHFcA KvGgh/vt2L6E9aNtQPnBg5KvRg3N+ZxXnEgZZ6OBb6SRDx1auGdLH5ODH oKPjA2f2Lpl+3/5I15mmHlpZjzQgD4vY5WPK6entEDv4STJGIcbcAVoNF 4=; Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by alexa-out-sd-01.qualcomm.com with ESMTP; 14 Feb 2022 08:41:34 -0800 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg02-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 08:41:34 -0800 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Mon, 14 Feb 2022 08:41:33 -0800 Received: from [10.110.63.253] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Mon, 14 Feb 2022 08:41:32 -0800 Message-ID: Date: Mon, 14 Feb 2022 08:41:31 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2] drm/msm/dp: always add fail-safe mode into connector mode list Content-Language: en-US To: , , , , , , , , CC: , , , , , References: <1643066274-25814-1-git-send-email-quic_khsieh@quicinc.com> From: Kuogee Hsieh In-Reply-To: <1643066274-25814-1-git-send-email-quic_khsieh@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen, Are you have more comments? On 1/24/2022 3:17 PM, Kuogee Hsieh wrote: > Some of DP link compliant test expects to return fail-safe mode > if prefer detailed timing mode can not be supported by mainlink's > lane and rate after link training. Therefore add fail-safe mode > into connector mode list as backup mode. This patch fixes test > case 4.2.2.1. > > Changes in v2: > -- add Fixes text string > > Fixes: 4b85d405cfe9 ( "drm/msm/dp: reduce link rate if failed at link training 1") > Signed-off-by: Kuogee Hsieh > --- > drivers/gpu/drm/msm/dp/dp_panel.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c > index 71db10c..f141872 100644 > --- a/drivers/gpu/drm/msm/dp/dp_panel.c > +++ b/drivers/gpu/drm/msm/dp/dp_panel.c > @@ -212,6 +212,11 @@ int dp_panel_read_sink_caps(struct dp_panel *dp_panel, > if (drm_add_modes_noedid(connector, 640, 480)) > drm_set_preferred_mode(connector, 640, 480); > mutex_unlock(&connector->dev->mode_config.mutex); > + } else { > + /* always add fail-safe mode as backup mode */ > + mutex_lock(&connector->dev->mode_config.mutex); > + drm_add_modes_noedid(connector, 640, 480); > + mutex_unlock(&connector->dev->mode_config.mutex); > } > > if (panel->aux_cfg_update_done) {