From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65883C4167B for ; Tue, 29 Nov 2022 16:36:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235139AbiK2QgC (ORCPT ); Tue, 29 Nov 2022 11:36:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235803AbiK2Qf4 (ORCPT ); Tue, 29 Nov 2022 11:35:56 -0500 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FE5E697DA for ; Tue, 29 Nov 2022 08:35:55 -0800 (PST) Received: by mail-lf1-x12d.google.com with SMTP id j16so22858584lfe.12 for ; Tue, 29 Nov 2022 08:35:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DozG8slifYUbIeG4p5hbkPUxWwGRFcCdA+vVxiWXmfs=; b=I9CBZQoGxjED9f6Xxs7R1Rh6NnUMmuWqQXJdRRmpJ19Mz89DIjvjAoIuZf7K9iWSBb BiuLtCwS1l8gbw3kmoN3yBnAy0UNEWGDVWoL2sM0tJjSRAYvll5qomZ569ewA9ysgSxU JzfdKhZGEjom0GwBUbMn2PSvs3xj6oK1LcdbY+Tk/SBTR5WTvgMJBNv2HG66Cws6pPO9 Sia8hauW5d44/JN0lbQF8CYJlynN0e2tJ0r9jPqXIbic6wHazU6w0R3BFFReizNVGZHf 3nghfdGrmHKOK8Kcx91mFYj0lzTVx4zPIFCmuqQfPRQHqdG09bfrB8NBJpuESEprcOvX cnnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DozG8slifYUbIeG4p5hbkPUxWwGRFcCdA+vVxiWXmfs=; b=KtwORwPmGJyROntdEeOVExfO2klsHL+CcPtKXqeeeD7sWtrrQdbOoPDQWXERazOCwv Suml7Nnk409ZfAcuCEVi3jmJJ5YuTMj5W5RO4hxonDVfZy4EIcSurV1GYkJBJmG10reY fUNey+6TKBeaYn9AUArZrSXSYqIN1AHtyYGq63zS1RaM8PW12UIc8wBNEbcZJvk8net+ psD4h3g81/Xpc48HKKm0SGXlOLCHoqhPgCZmVJzSXrQIZ523Zar68O5vZCnoNfHtx/zL KHaSrZ7XIds5KEBASDiPP8wCDK8E+xmEkxSL1kldrY2xRebY+8ZQeG4xpB7Ym13ufRE8 uQug== X-Gm-Message-State: ANoB5plHrGHAKY/AhPxkgrwXv6EWQDhlyAUumekKG+R3G2JF1vch46QF BOWQBz/fXt/LKf4nbI/XvxPmUQ== X-Google-Smtp-Source: AA0mqf6nIP2Y/A3+PfTGlbmjvNTL2zsWVEGp5bBox8UJh3b4flIMVZs/UJDXUOiNFTamoISUgQ+TEQ== X-Received: by 2002:ac2:4346:0:b0:4b4:a5c8:cc0f with SMTP id o6-20020ac24346000000b004b4a5c8cc0fmr21241693lfl.138.1669739753191; Tue, 29 Nov 2022 08:35:53 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id a26-20020a056512201a00b0049496608d58sm2240486lfb.155.2022.11.29.08.35.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 08:35:52 -0800 (PST) Message-ID: Date: Tue, 29 Nov 2022 17:35:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3 1/2] dt-bindings: interconnect: Add Qualcomm SM8550 Content-Language: en-US To: Abel Vesa , Andy Gross , Bjorn Andersson , Konrad Dybcio , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Neil Armstrong Cc: Linux Kernel Mailing List , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org References: <20221129131203.2197959-1-abel.vesa@linaro.org> <20221129131203.2197959-2-abel.vesa@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20221129131203.2197959-2-abel.vesa@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/11/2022 14:12, Abel Vesa wrote: > The Qualcomm SM8550 SoC has several bus fabrics that could be > controlled and tuned dynamically according to the bandwidth demand. > > Signed-off-by: Abel Vesa > --- > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sm8550-aggre1-noc > + - qcom,sm8550-aggre2-noc > + - qcom,sm8550-pcie-anoc > + then: > + required: > + - clocks > + else: > + properties: > + clocks: false > + > +required: > + - compatible > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + #include Keep headers sorted.... but actually these two look like not used. If you want to mention the header for interconnect IDs, you can add it in top level descritpion. > + > + clk_virt: interconnect-0 { > + compatible = "qcom,sm8550-clk-virt"; > + #interconnect-cells = <2>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + aggre1_noc: interconnect@16e0000 { > + compatible = "qcom,sm8550-aggre1-noc"; > + reg = <0x016e0000 0x14400>; > + #interconnect-cells = <2>; > + clocks = <&gcc GCC_AGGRE_UFS_PHY_AXI_CLK>, > + <&gcc GCC_AGGRE_USB3_PRIM_AXI_CLK>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; Your DTS example is oddly indented. I missed it during previous review. DTS examples go either with 2 or 4 spaces. Best regards, Krzysztof