From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E41CCEE6434 for ; Fri, 15 Sep 2023 07:44:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232659AbjIOHoj (ORCPT ); Fri, 15 Sep 2023 03:44:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232462AbjIOHoh (ORCPT ); Fri, 15 Sep 2023 03:44:37 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F21C898; Fri, 15 Sep 2023 00:44:32 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 6A51D5C01B2; Fri, 15 Sep 2023 03:44:32 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Fri, 15 Sep 2023 03:44:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1694763872; x=1694850272; bh=t1 TmiRsmiqzGQ86IPASUaWxEPOm0MoyVw2BuHDcx1xw=; b=r8mv8zbFk6D6NxtTWI 5mrt+5aqlY9VERclZBOqynYlvQFmz5g0VRZo1yQtWxu22/tCGM3RsYXzS+IDI+Nx FcvUBpqQtWHAhJyIeXwCD4wOE695pcAiHGwi2SrKMQ197aH5+A8sh0rCA5UuNnhP wU5GfJ8EZX1DQ1vfHNGuaYRId1AVnZW9Ggddi+Js4rZKmYwnDFNqBzs1hCPueP9V ssEqWtyH1LMJVA37Sk2SazF/+slcyLe0zB3lES4rMk4I+F7Jra0AmvZlF2fHvFoP ZEUPF1f4zKa1V1YbeuxdR4z3Bprd+dn+WJwLWDmVZFyfnzCYIF4egnQ2HF1+0raT wM/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1694763872; x=1694850272; bh=t1TmiRsmiqzGQ 86IPASUaWxEPOm0MoyVw2BuHDcx1xw=; b=fv/Q9eaOSWkOsYmE3FHcAmRB+LB5F U83bqXTW6iJuNsmj2rkJj34MREv+3fcBw0S3ZyBxx4Lu+VbGOhBrkPTPHcQhzUkP pa24usN37PmVaErVKFLKydJlifoXjFY15ET4pMpILu/IPb9kW3tTAxZd0qAWmZzV kYRr7rMY4l4x/Jrn8+jqS1lK7cPu4mTonig6+VBvypJmmrKFkbT310hXDrrgkTIu 44NIzymrx+Q3nuaSIXsW2t42zcvywND/jlM6x0CmmJkprpioJDT/Ag5vniwk+HME +lgEvEBrlbVgY85gM8/ay029ekva1WRWvM3D4mCUlGl04DrGKVPuW5yTQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudejuddguddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedt keetffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 4D769B60089; Fri, 15 Sep 2023 03:44:30 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-745-g95dd7bea33-fm-20230905.001-g95dd7bea Mime-Version: 1.0 Message-Id: In-Reply-To: <87sf7fvqiz.fsf@intel.com> References: <20230913113801.1901152-1-arnd@kernel.org> <874jjwx44g.fsf@intel.com> <763b1599-06b7-490e-9cbf-eb07f1deedb3@app.fastmail.com> <87sf7fvqiz.fsf@intel.com> Date: Fri, 15 Sep 2023 09:44:08 +0200 From: "Arnd Bergmann" To: "Jani Nikula" , "Masahiro Yamada" Cc: "Arnd Bergmann" , "Jonathan Corbet" , "Sakari Ailus" , "Javier Martinez Canillas" , "Nathan Chancellor" , "Nick Desaulniers" , "Nicolas Schier" , linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Documentation: kbuild: explain handling optional dependencies Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 15, 2023, at 09:34, Jani Nikula wrote: > > IS_REACHABLE() considered harmful. Absolutely agreed, and I'm sorry I introduced it in the first place in commit 9b174527e7b75 ("[media] Add and use IS_REACHABLE macro"). At the time, it was only used by drivers/media, which used to have a lot of open-coded instances of it and a lot of wrong checks. Having a formal syntax for it was an improvement for drivers/media since it was more broken before, but it's usually a mistake to use it when there is another solution, and we probably should have tried harder to fix the dependencies in drivers/media at the time. Arnd