From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BFC4C04FE0 for ; Wed, 9 Aug 2023 23:07:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233450AbjHIXHt (ORCPT ); Wed, 9 Aug 2023 19:07:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233002AbjHIXHo (ORCPT ); Wed, 9 Aug 2023 19:07:44 -0400 Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55E4D10DE for ; Wed, 9 Aug 2023 16:07:44 -0700 (PDT) Received: by mail-qk1-x72a.google.com with SMTP id af79cd13be357-768054797f7so23247685a.2 for ; Wed, 09 Aug 2023 16:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1691622463; x=1692227263; h=in-reply-to:references:subject:cc:to:from:message-id:date:from:to :cc:subject:date:message-id:reply-to; bh=sHK61T6EgbxK/w/h+u2OTZ46eXlV1WaAOWJmOQveL60=; b=gkjR2QtHz2DQFihjTgiuc1uY2qjpu9zys8jz6KgXSN7FqLZyqquHE0eJh4SGK6i83D rD218t5MopuA/4TP7POzZPoRawzonPU1L90DzSeIBG73sjbKALkHZN1sJShUCWOUHksz NEPcjLefA71RDAw7VBoHj75GENR3Ev2yYKKcvNItFB8cE0RRiQWuEOZjQngcw6XxSmHq qhhyGKX5pnigORXmHjSUErufD8ppeqnv9P8cNPRJAquWvWIAhrlFf7eDeAuxWMKAlEmF 79UKT0OSXc/hdvMy4EAvC4iawkeUKRuMH7C7ZgQgYwPi8GiVJNlg3HOWcAS7OT9IXccZ mjBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691622463; x=1692227263; h=in-reply-to:references:subject:cc:to:from:message-id:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sHK61T6EgbxK/w/h+u2OTZ46eXlV1WaAOWJmOQveL60=; b=kWMA2jzY+L73Zmicz4zDmvU7DX1+hkNStuouD60F5jjJghk7ZVNLWHwCfZ/cgcwNk5 XkEExKc6/yAu0qDUU8pUCm+BD4LfcXHXuNflhLcd7xGB+vIFfEu4qf8/BxckY9szAAmj hpsKwGe7+uFc9MtWOiH00u/WdZ4OuGykj2SIW4aUCV+V5emtcef96S+yUg72k198fjHp a/xqJh1bp5pXaQP64/zN2OiG2YQ78yEJx3sVjdnxiPea0aQutxGS3zsbeLXerdOt5u9x IDtMcSN5a2Ute93EVPCA0g1vWCiHgi7YTs8cLWQbAE4AgRiLzSVKylOnXM/TRs/OeGFr QB3Q== X-Gm-Message-State: AOJu0YwzwV0Ngt3Q+/FO9NUlw7y00NhYhPzxRkrdY2YevgmukNmP5EYM OuRtKLt366ciTa4hshNHzvUC2rr9c2c2UfBtRZLK X-Google-Smtp-Source: AGHT+IG4zDPfU/zDa5sG1B+ZHVEFI1O2Ivcjs1oMRzZkRBurX+fNIrzdu5EPrQpKRZq0kCYmj1ohXw== X-Received: by 2002:a05:620a:90a:b0:768:13b6:e9e7 with SMTP id v10-20020a05620a090a00b0076813b6e9e7mr427080qkv.63.1691622463415; Wed, 09 Aug 2023 16:07:43 -0700 (PDT) Received: from localhost ([70.22.175.108]) by smtp.gmail.com with ESMTPSA id s29-20020a05620a031d00b00767e62bcf0csm49515qkm.65.2023.08.09.16.07.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Aug 2023 16:07:43 -0700 (PDT) Date: Wed, 09 Aug 2023 19:07:42 -0400 Message-ID: From: Paul Moore To: =?UTF-8?q?Christian=20G=C3=B6ttsche?= , selinux@vger.kernel.org Cc: Stephen Smalley , Eric Paris , Ondrej Mosnacek , "GONG, Ruiqi" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/7] selinux: update type for number of class permissions in services code References: <20230807171143.208481-2-cgzones@googlemail.com> In-Reply-To: <20230807171143.208481-2-cgzones@googlemail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Aug 7, 2023 =?UTF-8?q?Christian=20G=C3=B6ttsche?= wrote: > > Security classes have only up to 32 permissions, hence using an u16 is > sufficient (while improving padding in struct selinux_mapping). > > Signed-off-by: Christian Göttsche > --- > v3: > - drop type change of arithmetic variable; it might effect performance > as suggested by David. > - split bogus and corrected cast into separate patch > v2: > update commit description: > - mention struct selinux_mapping in the padding argument > (currently between the first and second member there are 2 bytes > padding) > - mention overflow in the cast argument and the result of setting > no bits due to it > --- > security/selinux/ss/services.c | 2 +- > security/selinux/ss/services.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Merged into selinux/next, thanks. -- paul-moore.com