From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751459AbdINAcw (ORCPT ); Wed, 13 Sep 2017 20:32:52 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:47673 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751279AbdINAct (ORCPT ); Wed, 13 Sep 2017 20:32:49 -0400 X-ME-Sender: X-Sasl-enc: w9XUeUpt2kakbC9Vh+XIfatpCypkk329HUudPiDSa0Nv 1505349168 Subject: Re: [RFC PATCH 0/2] autofs: fix autofs_v5_packet dlivery in compat mode To: Stanislav Kinsburskiy Cc: autofs@vger.kernel.org, linux-kernel@vger.kernel.org, devel@openvz.org, ldv@altlinux.org References: <20170901110906.2669.1577.stgit@localhost.localdomain> From: Ian Kent Message-ID: Date: Thu, 14 Sep 2017 08:32:43 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170901110906.2669.1577.stgit@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/09/17 19:21, Stanislav Kinsburskiy wrote: > The problem is that in compat mode struct autofs_v5_packet has to have different size > (i.e. 4 bytes less). I regret (several times over) my original decision to not make v5 packets packed .... I have to say the description of the problem is not all that good. > > This is RFC because: > 1) This issue is hidden, because autofs pipe has O_DIRECT and the rest of the > epacket is truncated when read. > 2) X86 arch doesn't have is_compat_task() helper > 3) It's now clear, what to do if "pgrp" option is specified. I don't understand what the "pgrp" option has to do with this? > > The following series implements... > > --- > > Stanislav Kinsburskiy (2): > autofs: set compat flag on sbi when daemon uses 32bit addressation > autofs: sent 32-bit sized packet for 32-bit process > > > fs/autofs4/autofs_i.h | 3 +++ > fs/autofs4/dev-ioctl.c | 3 +++ > fs/autofs4/inode.c | 4 +++- > fs/autofs4/waitq.c | 5 +++++ > 4 files changed, 14 insertions(+), 1 deletion(-) >