From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752967AbdBCJiV (ORCPT ); Fri, 3 Feb 2017 04:38:21 -0500 Received: from mx2.suse.de ([195.135.220.15]:42461 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752657AbdBCJiT (ORCPT ); Fri, 3 Feb 2017 04:38:19 -0500 Subject: Re: [PATCH] xen-netfront: Delete rx_refill_timer in xennet_disconnect_backend() To: Boris Ostrovsky References: <1485798346-4425-1-git-send-email-boris.ostrovsky@oracle.com> Cc: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, vineethp@amazon.com, wei.liu2@citrix.com, paul.durrant@citrix.com, stable@vger.kernel.org From: Juergen Gross Message-ID: Date: Fri, 3 Feb 2017 10:38:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1485798346-4425-1-git-send-email-boris.ostrovsky@oracle.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/01/17 18:45, Boris Ostrovsky wrote: > rx_refill_timer should be deleted as soon as we disconnect from the > backend since otherwise it is possible for the timer to go off before > we get to xennet_destroy_queues(). If this happens we may dereference > queue->rx.sring which is set to NULL in xennet_disconnect_backend(). > > Signed-off-by: Boris Ostrovsky > CC: stable@vger.kernel.org Reviewed-by: Juergen Gross Juergen