mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To: "Gregory CLEMENT" <gregory.clement@bootlin.com>,
	"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>
Cc: "Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
	"Théo Lebrun" <theo.lebrun@bootlin.com>,
	"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: CPS: Optimise delay CPU calibration for SMP
Date: Thu, 22 May 2025 16:10:35 +0100	[thread overview]
Message-ID: <bc3dd9ed-0fab-4f62-a55b-8ce33fea10f0@app.fastmail.com> (raw)
In-Reply-To: <87iklsofih.fsf@BLaptop.bootlin.com>



在2025年5月22日周四 下午4:02,Gregory CLEMENT写道:
[...]
>
> I didn't notice this function initially, but upon closer inspection, it
> appears that although the scan process is optimized, it still performs a
> full scan for each CPU during boot. In contrast, with the mask, the
> information is created only once and within an existing loop.
>
> I believe this function would benefit from __cpu_primary_cluster_mask,
> which is why I prefer my current implementation over using
> mips_cps_first_online_in_cluster().

Thanks for clarification!

My concern is __cpu_primary_cluster_mask is pretty limited and the concept
of "primary cpu" is kind of fragile.

To optimize mips_cps_first_online_in_cluster I think the best way forward
would be produce cpumask for each cluster and perform cpumask_or with online
cpu mask at runtime. cluster_cpumask can be reused by other logic later.

Anyway, it's just my two cents.

Thanks
-- 
- Jiaxun

      reply	other threads:[~2025-05-22 15:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-20 15:21 Gregory CLEMENT
2025-05-20 15:35 ` Jiaxun Yang
2025-05-21  7:47   ` Gregory CLEMENT
2025-05-22 13:03     ` Jiaxun Yang
2025-05-22 15:02       ` Gregory CLEMENT
2025-05-22 15:10         ` Jiaxun Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc3dd9ed-0fab-4f62-a55b-8ce33fea10f0@app.fastmail.com \
    --to=jiaxun.yang@flygoat.com \
    --cc=gregory.clement@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=tawfik.bayouk@mobileye.com \
    --cc=theo.lebrun@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tsbogend@alpha.franken.de \
    --cc=vladimir.kondratiev@mobileye.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®