mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@kernel.org>
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>, Rong Xu <xur@google.com>,
	Han Shen <shenhan@google.com>,
	Sriraman Tallam <tmsriram@google.com>,
	Krzysztof Pszeniczny <kpszeniczny@google.com>
Subject: [PATCH 3/6] objtool: Don't alias undefined symbols
Date: Thu, 20 Nov 2025 12:52:17 -0800	[thread overview]
Message-ID: <bc401173a7717757eee672fc1ca5a20451d77b86.1763671318.git.jpoimboe@kernel.org> (raw)
In-Reply-To: <cover.1763671318.git.jpoimboe@kernel.org>

Objtool is mistakenly aliasing all undefined symbols.  That's obviously
wrong, though it has no consequence since objtool happens to only use
sym->alias for defined symbols.  Fix it regardless.

Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
---
 tools/objtool/elf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c
index fffca31d47ed..4f15643ad70c 100644
--- a/tools/objtool/elf.c
+++ b/tools/objtool/elf.c
@@ -492,8 +492,8 @@ static int elf_add_symbol(struct elf *elf, struct symbol *sym)
 	sym->len = sym->sym.st_size;
 
 	__sym_for_each(iter, &sym->sec->symbol_tree, sym->offset, sym->offset) {
-		if (iter->offset == sym->offset && iter->type == sym->type &&
-		    iter->len == sym->len)
+		if (!is_undef_sym(iter) && iter->offset == sym->offset &&
+		    iter->type == sym->type && iter->len == sym->len)
 			iter->alias = sym;
 	}
 
-- 
2.51.1


  parent reply	other threads:[~2025-11-20 20:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20 20:52 [PATCH 0/6] objtool: AUTOFDO fixes + alias improvements Josh Poimboeuf
2025-11-20 20:52 ` [PATCH 1/6] objtool: Support Clang AUTOFDO .cold functions Josh Poimboeuf
2025-11-20 22:18   ` Rong Xu
2025-11-21  9:58   ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2025-11-20 20:52 ` [PATCH 2/6] objtool: Fix .cold function detection for duplicate symbols Josh Poimboeuf
2025-11-21  9:57   ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2025-11-20 20:52 ` Josh Poimboeuf [this message]
2025-11-21  9:57   ` [tip: objtool/core] objtool: Don't alias undefined symbols tip-bot2 for Josh Poimboeuf
2025-11-20 20:52 ` [PATCH 4/6] objtool: Return canonical symbol when aliases exist in symbol finding helpers Josh Poimboeuf
2025-11-21  9:57   ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2025-11-20 20:52 ` [PATCH 5/6] objtool: Skip non-canonical aliased symbols in add_jump_table_alts() Josh Poimboeuf
2025-11-21  9:57   ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2025-11-20 20:52 ` [PATCH 6/6] objtool: Remove second pass of .cold function correlation Josh Poimboeuf
2025-11-21  9:57   ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc401173a7717757eee672fc1ca5a20451d77b86.1763671318.git.jpoimboe@kernel.org \
    --to=jpoimboe@kernel.org \
    --cc=kpszeniczny@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=shenhan@google.com \
    --cc=tmsriram@google.com \
    --cc=x86@kernel.org \
    --cc=xur@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®