mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@kernel.org>
To: Frank Li <Frank.li@nxp.com>, Sherry Sun <sherry.sun@nxp.com>
Cc: gregkh@linuxfoundation.org, shawnguo@kernel.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, shenwei.wang@nxp.com, peng.fan@nxp.com,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	imx@lists.linux.dev
Subject: Re: [PATCH V3 2/2] tty: serial: imx: Add missing wakeup event reporting
Date: Mon, 29 Sep 2025 07:58:05 +0200	[thread overview]
Message-ID: <bc4beaa6-8391-4ba8-b6c4-bde1c00d0375@kernel.org> (raw)
In-Reply-To: <aNVkhvmZ4GThHNqD@lizhi-Precision-Tower-5810>

On 25. 09. 25, 17:49, Frank Li wrote:
>> @@ -2732,10 +2734,14 @@ static void imx_uart_enable_wakeup(struct imx_port *sport, bool on)
>>   			ucr1 |= UCR1_RTSDEN;
>>   		} else {
>>   			ucr1 &= ~UCR1_RTSDEN;
>> +			wake_active |= !!(usr1 & USR1_RTSD);
> 
> I think you miss understand my means. suppose bool type only support
> ||, &&, ==, !=, !
> 
> 	wake_active = wake_active || (usr1 & USR1_RTSD);

+1 to this. Much easier to understand (for me at least).

thanks,
-- 
js
suse labs

  reply	other threads:[~2025-09-29  5:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-25  9:11 [PATCH V3 0/2] tty: serial: imx: improve the imx uart wakeup function Sherry Sun
2025-09-25  9:11 ` [PATCH V3 1/2] tty: serial: imx: Only configure the wake register when device is set as wakeup source Sherry Sun
2025-09-29  5:54   ` Jiri Slaby
2025-10-02  4:32     ` Sherry Sun
2025-09-25  9:11 ` [PATCH V3 2/2] tty: serial: imx: Add missing wakeup event reporting Sherry Sun
2025-09-25 15:49   ` Frank Li
2025-09-29  5:58     ` Jiri Slaby [this message]
2025-10-02  3:44       ` Sherry Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc4beaa6-8391-4ba8-b6c4-bde1c00d0375@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=Frank.li@nxp.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=shenwei.wang@nxp.com \
    --cc=sherry.sun@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®